Skip to content

[Upgrade] to lucene-9.4.0-snapshot-ddf0d0a#4183

Merged
nknize merged 3 commits into
opensearch-project:mainfrom
nknize:upgrade/lucene9.4-snapshot-ddf0d0a
Aug 15, 2022
Merged

[Upgrade] to lucene-9.4.0-snapshot-ddf0d0a#4183
nknize merged 3 commits into
opensearch-project:mainfrom
nknize:upgrade/lucene9.4-snapshot-ddf0d0a

Conversation

@nknize
Copy link
Copy Markdown
Contributor

@nknize nknize commented Aug 10, 2022

Upgrades to latest snapshot of lucene 9.4.

@nknize nknize added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0 labels Aug 10, 2022
@nknize nknize requested review from a team and reta as code owners August 10, 2022 14:51
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize nknize marked this pull request as draft August 10, 2022 18:31
Comment on lines 125 to 128
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what was the use of this and when we are removing it will this impact anything.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't impact anything since the setScorer method is a noop

@nknize nknize force-pushed the upgrade/lucene9.4-snapshot-ddf0d0a branch from 2233fa2 to e456618 Compare August 12, 2022 20:44
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

nknize added 3 commits August 15, 2022 11:56
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize force-pushed the upgrade/lucene9.4-snapshot-ddf0d0a branch from e456618 to 38c237c Compare August 15, 2022 16:56
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Copy Markdown
Contributor Author

nknize commented Aug 15, 2022

Hmm.. can't repro locally. Refiring and will continue to dig...

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.index.fielddata.SortedSetDVStringFieldDataTests.testSortMissingFirst" -Dtests.seed=3AA5F19D0B1A959 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar -Dtests.timezone=America/Mexico_City -Druntime.java=17
NOTE: leaving temporary files on disk at: /var/jenkins/workspace/gradle-check/search/server/build/testrun/test/temp/org.opensearch.index.fielddata.SortedSetDVStringFieldDataTests_3AA5F19D0B1A959-001
java.lang.AssertionError: expected:<1055> but was:<1053>
	at __randomizedtesting.SeedInfo.seed([3AA5F19D0B1A959:90B5BA3675D39746]:0)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
	at org.opensearch.index.fielddata.AbstractStringFieldDataTestCase.testSortMissing(AbstractStringFieldDataTestCase.java:343)
	at org.opensearch.index.fielddata.AbstractStringFieldDataTestCase.testSortMissingFirst(AbstractStringFieldDataTestCase.java:301)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

@nknize
Copy link
Copy Markdown
Contributor Author

nknize commented Aug 15, 2022

start gradle check

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize nknize marked this pull request as ready for review August 15, 2022 19:46
final BytesRef missingBytes = (BytesRef) missingObject(missingValue, reversed);
if (indexFieldData instanceof IndexOrdinalsFieldData) {
return new FieldComparator.TermOrdValComparator(numHits, null, sortMissingLast) {
FieldComparator<?> cmp = new TermOrdValComparator(numHits, indexFieldData.getFieldName(), sortMissingLast, reversed) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nknize This may have caused a regression, see https://build.ci.opensearch.org/job/gradle-check/1941/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Also in https://build.ci.opensearch.org/job/gradle-check/1752/ associated with this PR)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard the above. Found the problem elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants