[Upgrade] to lucene-9.4.0-snapshot-ddf0d0a#4183
Merged
nknize merged 3 commits intoAug 15, 2022
Merged
Conversation
Contributor
Gradle Check (Jenkins) Run Completed with:
|
navneet1v
reviewed
Aug 11, 2022
Comment on lines
125
to
128
Contributor
There was a problem hiding this comment.
not sure what was the use of this and when we are removing it will this impact anything.
Contributor
Author
There was a problem hiding this comment.
It doesn't impact anything since the setScorer method is a noop
2233fa2 to
e456618
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
e456618 to
38c237c
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Author
|
Hmm.. can't repro locally. Refiring and will continue to dig... |
Contributor
Author
|
start gradle check |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
Aug 15, 2022
5 tasks
dbwiddis
reviewed
Aug 19, 2022
| final BytesRef missingBytes = (BytesRef) missingObject(missingValue, reversed); | ||
| if (indexFieldData instanceof IndexOrdinalsFieldData) { | ||
| return new FieldComparator.TermOrdValComparator(numHits, null, sortMissingLast) { | ||
| FieldComparator<?> cmp = new TermOrdValComparator(numHits, indexFieldData.getFieldName(), sortMissingLast, reversed) { |
Member
There was a problem hiding this comment.
@nknize This may have caused a regression, see https://build.ci.opensearch.org/job/gradle-check/1941/
Member
There was a problem hiding this comment.
(Also in https://build.ci.opensearch.org/job/gradle-check/1752/ associated with this PR)
Member
There was a problem hiding this comment.
Disregard the above. Found the problem elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades to latest snapshot of lucene 9.4.