[Feature/extensions] Adding support for registering Transport Actions for extensions#4326
Merged
saratvemulapalli merged 5 commits intoopensearch-project:feature/extensionsfrom Sep 1, 2022
Conversation
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
saratvemulapalli
requested review from
dbwiddis,
joshpalis,
owaiskazi19 and
ryanbogan
owaiskazi19
reviewed
Aug 31, 2022
| public static final String REQUEST_EXTENSION_LOCAL_NODE = "internal:discovery/localnode"; | ||
| public static final String REQUEST_EXTENSION_CLUSTER_SETTINGS = "internal:discovery/clustersettings"; | ||
| public static final String REQUEST_EXTENSION_REGISTER_REST_ACTIONS = "internal:discovery/registerrestactions"; | ||
| public static final String REQUEST_EXTENSION_REGISTER_TRANSPORT_ACTIONS = "internal:discovery/registertransportactions"; |
Member
There was a problem hiding this comment.
Are we having separate action for extensions?
Member
Author
There was a problem hiding this comment.
There is an open issue: #4334. Lets do a sweep all together in a dedicated PR.
dbwiddis
reviewed
Aug 31, 2022
server/src/main/java/org/opensearch/extensions/RegisterTransportActionsRequest.java
Show resolved
Hide resolved
dbwiddis
reviewed
Aug 31, 2022
server/src/main/java/org/opensearch/extensions/RegisterTransportActionsRequest.java
Show resolved
Hide resolved
joshpalis
reviewed
Aug 31, 2022
server/src/main/java/org/opensearch/extensions/RegisterTransportActionsRequest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
dbwiddis
approved these changes
Sep 1, 2022
Member
dbwiddis
left a comment
dbwiddis
left a comment
There was a problem hiding this comment.
LGTM. One optional comment inline
|
|
||
| BytesStreamOutput output = new BytesStreamOutput(); | ||
| originalRequest.writeTo(output); | ||
| StreamInput input = output.bytes().streamInput(); |
Member
There was a problem hiding this comment.
(Comment) I realize that close() is a noop here so these don't need to be closed, but some IDE linters will complain that a resource isn't closed. Personal preference of mine. :)
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## feature/extensions #4326 +/- ##
========================================================
- Coverage 70.61% 70.60% -0.02%
- Complexity 57271 57332 +61
========================================================
Files 4633 4634 +1
Lines 275817 275849 +32
Branches 40337 40340 +3
========================================================
- Hits 194763 194752 -11
- Misses 64722 64798 +76
+ Partials 16332 16299 -33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
Author
|
@owaiskazi19 Waiting for the 2nd review. |
owaiskazi19
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sarat Vemulapalli vemulapallisarat@gmail.com
Description
Adds support for registering Transport Actions for extensions.
Issues Resolved
Closes opensearch-project/opensearch-sdk-java#105
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.