[Feature/extensions] Handle named wildcards (REST path parameters)#4415
Conversation
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/extensions/rest/RestSendToExtensionAction.java
Show resolved
Hide resolved
saratvemulapalli
left a comment
There was a problem hiding this comment.
Thanks @dbwiddis for the change.
Is there a way to unit test this?
@saratvemulapalli Not really as it relies on communications from the extension. I hope to cover it as part of my integration test issue #120. Also, I think while this works for the "happy path" I think (but am not sure) that we need special handling for the timeout case and the exception case. I'll handle that as part of the IT work as well. Also full completion of this work is somewhat dependent on #111 being complete. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
1 similar comment
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
@dbwiddis looks like we have to rebase |
Signed-off-by: Daniel Widdis <widdis@gmail.com>
79c8676 to
2a49d5a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/extensions #4415 +/- ##
========================================================
- Coverage 70.61% 70.51% -0.11%
+ Complexity 57436 57361 -75
========================================================
Files 4641 4641
Lines 276249 276257 +8
Branches 40384 40386 +2
========================================================
- Hits 195083 194796 -287
- Misses 64847 65117 +270
- Partials 16319 16344 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Companion PR: opensearch-project/opensearch-sdk-java#123
Description
Adds the ability to handle REST path parameters (named wildcards). Most changes are on the SDK repo. However, it is necessary (see Javadoc) for the
prepareRequest()method to indicate which parameters were consumed. If the user provides too many parameters, they receive an error.In local/plugin operation, simply fetching the parameter via
param(key)consumes it. Since the parameters are being consumed remotely, this requires communicating the list of consumed parameters, which is done in the response header (normally unused and provided for purposes such as this!)Issues Resolved
Fixes SDK #122
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.