Migrate client transports to Apache HttpClient / Core 5.x by reta · Pull Request #4459 · opensearch-project/OpenSearch

reta · 2022-09-08T17:16:47Z

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Migrate client transports to Apache HttpClient / Core 5.x

Issues Resolved

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2022-09-08T17:17:23Z

Gradle Check (Jenkins) Run Completed with:

RESULT: null ❌
URL: null
CommitID: fe4996d

github-actions · 2022-09-08T17:23:08Z

Gradle Check (Jenkins) Run Completed with:

RESULT: null ❌
URL: null
CommitID: 340c027

github-actions · 2022-09-08T18:18:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2892/
CommitID: f29fa47

github-actions · 2022-09-08T18:26:08Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2893/
CommitID: 4ca7793

github-actions · 2022-09-08T19:20:27Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2894/
CommitID: 5206bd8

github-actions · 2022-09-12T20:14:56Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2983/
CommitID: 5206bd8

github-actions · 2022-09-21T07:33:39Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3287/
CommitID: 3fc8a3b

github-actions · 2022-09-21T14:15:20Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3292/
CommitID: c0cdeea

github-actions · 2022-09-26T16:12:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3410/
CommitID: 431dde2

github-actions · 2022-09-26T18:38:03Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3431/
CommitID: a0aca92

github-actions · 2022-09-26T19:46:26Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3435/
CommitID: 803d912

github-actions · 2022-09-26T20:31:19Z

Gradle Check (Jenkins) Run Completed with:

RESULT: null ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3441/
CommitID: 27e92a5

github-actions · 2022-09-27T14:27:44Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3471/
CommitID: 27e92a5

github-actions · 2022-09-27T18:31:03Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3491/
CommitID: f30a229

github-actions · 2022-09-27T18:48:22Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3492/
CommitID: 53994bb

github-actions · 2022-09-27T20:26:02Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3498/
CommitID: 3faf3dc

dblock

Admire your persistence @reta :) Did a cursory look and it looks all good to me. Are there any actual notable code changes that I may have missed or is it just a rename/moving things around?

reta · 2022-10-06T14:57:38Z

Admire your persistence @reta :) Did a cursory look and it looks all good to me. Are there any actual notable code changes that I may have missed or is it just a rename/moving things around?

Thanks a mill @dblock ! There are two things I wanted to finish: a) to compare the CPU/memory usage between RestClient based on Apache HttpClient 4 vs 5.1, to make sure we have no leaks anywhere b) try to configure RestClient with HTTP/2.

Besides that, there is only one issue to mention which should be fixed in 5.1.4 release [1], other changes are pretty straightforward, thanks a lot for the review!

[1] https://github.com/opensearch-project/OpenSearch/pull/4459/files#diff-7c27327b9ea112ce87560831ddb6bd267e80837cd51c03796c8e2397f5b8a6a7R908

dblock · 2022-10-06T15:05:06Z

👍 feel free to merge at will

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

github-actions · 2022-10-11T18:59:36Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/4429/
CommitID: 9e4daf6

dblock · 2022-10-11T20:59:27Z

~~Merge?~~ YOLO

saratvemulapalli · 2022-10-13T18:17:49Z

@dblock @reta looks like few plugins are failing.
Are we planing to get these changes to 2.x ?

dblock · 2022-10-14T19:58:02Z

@saratvemulapalli That would be breaking for 2.x, so no?

reta · 2022-10-17T02:18:21Z

@saratvemulapalli That would be breaking for 2.x, so no?

:+1 to @dblock's answer, sadly will be breaking change

saratvemulapalli · 2022-10-18T21:10:56Z

Thanks @reta @dblock. I've added this to #3351 .

…-project#4459) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta force-pushed the issue-4256 branch from fe4996d to 340c027 Compare September 8, 2022 17:22

reta force-pushed the issue-4256 branch 2 times, most recently from f29fa47 to 4ca7793 Compare September 8, 2022 18:11

reta changed the base branch from issue-4256 to main September 8, 2022 18:12

reta force-pushed the issue-4256 branch from 4ca7793 to 5206bd8 Compare September 8, 2022 19:09

reta force-pushed the issue-4256 branch from 5206bd8 to 3fc8a3b Compare September 21, 2022 07:21

reta force-pushed the issue-4256 branch from 3fc8a3b to c0cdeea Compare September 21, 2022 14:07

reta force-pushed the issue-4256 branch from c0cdeea to 431dde2 Compare September 26, 2022 16:04

reta force-pushed the issue-4256 branch from 431dde2 to a0aca92 Compare September 26, 2022 18:25

reta force-pushed the issue-4256 branch from a0aca92 to 803d912 Compare September 26, 2022 19:37

reta force-pushed the issue-4256 branch from 803d912 to 27e92a5 Compare September 26, 2022 20:24

reta force-pushed the issue-4256 branch 2 times, most recently from f30a229 to 53994bb Compare September 27, 2022 18:25

reta force-pushed the issue-4256 branch from 53994bb to 3faf3dc Compare September 27, 2022 20:01

dblock approved these changes Oct 6, 2022

View reviewed changes

Migrate client transports to Apache HttpClient / Core 5.x

9e4daf6

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta force-pushed the issue-4256 branch from 5e0238f to 9e4daf6 Compare October 11, 2022 18:29

dblock merged commit 4833e08 into opensearch-project:main Oct 11, 2022

DarshitChanpura mentioned this pull request Oct 13, 2022

[Failing CI] Main branch build is failing opensearch-project/security#2165

Closed

saratvemulapalli mentioned this pull request Oct 13, 2022

Added groupId as org.opensearch.plugin in pluginZip publication opensearch-project/job-scheduler#251

Merged

5 tasks

joshpalis mentioned this pull request Oct 13, 2022

Updating Apache Http imports to Apache HttpClient / Core 5.x opensearch-project/job-scheduler#254

Merged

5 tasks

cwperks mentioned this pull request Oct 18, 2022

Migrate to Apache HttpClient / Core 5.x opensearch-project/security#2166

Merged

3 tasks

saratvemulapalli mentioned this pull request Oct 18, 2022

[META] Breaking changes in 3.0 #3351

Closed

26 tasks

joshpalis mentioned this pull request Nov 1, 2022

[BUG] SDKClient test failures due to Apache HttpClient / Core 5.x upgrade opensearch-project/opensearch-sdk-java#210

Closed

saratvemulapalli mentioned this pull request Dec 14, 2022

[BUG] Getting DeadlineTimeoutException error during security tests after upgrading to 3.0 opensearch-project/notifications#580

Closed

joshpalis mentioned this pull request Jan 20, 2023

[BUG] SDK is not working with OpenSearch 2.x opensearch-project/opensearch-sdk-java#345

Closed

brokemyspoke mentioned this pull request Jun 21, 2023

elasticsearch-rest-client is using an old non-maintained version of httpasyncclient-4.1.4.jar #1308

Open

AhmadMS1988 mentioned this pull request Sep 3, 2023

Include HttpClient 5.X for the rest client #9718

Closed

kaituo mentioned this pull request Mar 27, 2024

[backport to 2.x] rebase main opensearch-project/anomaly-detection#1180

Merged

cwperks mentioned this pull request Apr 24, 2025

[Resource Permissions] Introduces Centralized Resource Access Control Framework opensearch-project/security#5281

Merged

3 tasks

BrewTestBot mentioned this pull request May 6, 2025

opensearch 3.0.0 Homebrew/homebrew-core#222665

Merged

ps48 mentioned this pull request Aug 7, 2025

Upgrade to OpenSearch 3.0.0 opensearch-project/opensearch-prometheus-exporter#369

Merged

5 tasks

Conversation

reta commented Sep 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

github-actions bot commented Sep 8, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 8, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 8, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 8, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 8, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 12, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 21, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 21, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

dblock left a comment

Choose a reason for hiding this comment

Uh oh!

reta commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dblock commented Oct 6, 2022

Uh oh!

github-actions bot commented Oct 11, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

dblock commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saratvemulapalli commented Oct 13, 2022

Uh oh!

dblock commented Oct 14, 2022

Uh oh!

reta commented Oct 17, 2022

Uh oh!

saratvemulapalli commented Oct 18, 2022

Uh oh!

Reviewers

Assignees

Labels

reta commented Sep 8, 2022 •

edited

Loading

reta commented Oct 6, 2022 •

edited

Loading

dblock commented Oct 11, 2022 •

edited

Loading