Add changes for graceful node decommission by pranikum · Pull Request #4586 · opensearch-project/OpenSearch

pranikum · 2022-09-25T17:21:33Z

Signed-off-by: pranikum 109206473+pranikum@users.noreply.github.com

Description

Changes for graceful decommission of nodes. This includes call to WRR api.
Can be merged once decommission API and WRR changes are merged.

Depends on :
#4272
#4241

Issues Resolved

#4083

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-25T17:29:23Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3372/
CommitID: bdb6c6f

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-25T18:03:11Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3373/
CommitID: afec689

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-25T18:55:25Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3374/
CommitID: 3314ec3

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-25T19:37:31Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3375/
CommitID: bf622c4

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-26T02:39:19Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3378/
CommitID: d933377

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-26T03:00:42Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3379/
CommitID: bf4c217

github-actions · 2022-09-26T03:18:44Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3380/
CommitID: c57530a

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-26T05:54:48Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3381/
CommitID: 7c43ad1

server/src/main/java/org/opensearch/cluster/decommission/DecommissionController.java

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-26T13:42:08Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3401/
CommitID: ba8f500

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-26T14:44:34Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3407/
CommitID: 8920480

github-actions · 2022-09-26T14:55:41Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3408/
CommitID: eeed711

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-26T15:55:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3409/
CommitID: ed1ccbc

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-27T08:33:49Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3462/
CommitID: 7922291

github-actions · 2022-10-21T11:05:16Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5168/
CommitID: 10a6e5f

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-10-21T11:47:49Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5170/
CommitID: d2d171d

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-10-24T08:24:33Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5332/
CommitID: 68e4e94

github-actions · 2022-10-24T08:30:59Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5333/
CommitID: 04e4676

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-10-24T17:52:55Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5381/
CommitID: a6fbdb2

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-10-25T01:33:21Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5495/
CommitID: 122b16c

Bukhtawar

Lets add assertions in the integration tests for voting configuration values

imRishN · 2022-10-26T07:14:59Z

...java/org/opensearch/action/admin/cluster/decommission/awareness/put/DecommissionRequest.java

    public DecommissionRequest(StreamInput in) throws IOException {
        super(in);
        decommissionAttribute = new DecommissionAttribute(in);
+        this.delayTimeout = in.readTimeValue();


We missed adding noDelay here. With this no delay would never be read from the request

* Add changes for graceful node decommission Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

* Add changes for graceful node decommission Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Fail weight update when decommission ongoing and fail decommission when attribute not weighed away (#4839) * Add changes for graceful node decommission (#4586) * Add delay timeout for decommission request (#4931) * Integ Tests for Awareness Attribute Decommissioning (#4715) Signed-off-by: Rishab Nahata <rnnahata@amazon.com> Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

* Fail weight update when decommission ongoing and fail decommission when attribute not weighed away (opensearch-project#4839) * Add changes for graceful node decommission (opensearch-project#4586) * Add delay timeout for decommission request (opensearch-project#4931) * Integ Tests for Awareness Attribute Decommissioning (opensearch-project#4715) Signed-off-by: Rishab Nahata <rnnahata@amazon.com> Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

* Add changes for graceful node decommission Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Add changes for graceful node decommission

bdb6c6f

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum requested review from a team and reta as code owners September 25, 2022 17:21

Add WRRWeights class

afec689

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Add logger message

3314ec3

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Add tests

bf622c4

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Remove unused code

d933377

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum added 2 commits September 26, 2022 08:11

Remove test annonation

bf4c217

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Fix spotless

c57530a

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Add package info

7c43ad1

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

gbbafna requested changes Sep 26, 2022

View reviewed changes

Add weigh away status

ba8f500

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum added 2 commits September 26, 2022 19:49

PR comments

8920480

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Update changelog

eeed711

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Fix tests

ed1ccbc

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Remove time check. Just we will schedule

7922291

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

gbbafna approved these changes Sep 27, 2022

View reviewed changes

Empty-Commit

d2d171d

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum requested a review from Bukhtawar October 21, 2022 14:52

pranikum added 4 commits October 24, 2022 13:24

In case of no delay.. Avoid draining state

68e4e94

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Merging with lates

d6fe3c4

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Merge branch 'main' into graceful-node-decommission-wrr-2

ca0418f

Resolve conflict with main

04e4676

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Fix test

a6fbdb2

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum added 3 commits October 25, 2022 06:31

Take latest file

811fe8e

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Merge branch 'main' into graceful-node-decommission-wrr-2

97c93c1

Resolve conflict

122b16c

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Bukhtawar approved these changes Oct 25, 2022

View reviewed changes

Bukhtawar merged commit 1a40bd5 into opensearch-project:main Oct 25, 2022

imRishN reviewed Oct 26, 2022

View reviewed changes

imRishN mentioned this pull request Oct 29, 2022

Integ Tests for Awareness Attribute Decommissioning #4715

Merged

6 tasks

pranikum added a commit to pranikum/OpenSearch that referenced this pull request Nov 3, 2022

Add changes for graceful node decommission (opensearch-project#4586)

09cc5e7

* Add changes for graceful node decommission Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum mentioned this pull request Nov 3, 2022

[Enhancement]: Discuss the Node draining state feasiblity. #4866

Closed

imRishN mentioned this pull request Nov 3, 2022

[Backport 2.x]Graceful Decommission and Integ Tests #5060

Merged

6 tasks

imRishN mentioned this pull request Nov 4, 2022

[DOC] Awareness Attribute Decommission opensearch-project/documentation-website#1812

Closed

4 tasks

ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Nov 7, 2022

Add changes for graceful node decommission (opensearch-project#4586)

7c9194e

* Add changes for graceful node decommission Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum mentioned this pull request Jun 7, 2023

[Draft]: Graceful decommission support #4082

Closed

5 tasks

pranikum deleted the graceful-node-decommission-wrr-2 branch July 17, 2025 03:13

Conversation

pranikum commented Sep 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

github-actions bot commented Sep 25, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 25, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 25, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 25, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 24, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 24, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 24, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 25, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Bukhtawar left a comment

Choose a reason for hiding this comment

Uh oh!

imRishN Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

pranikum commented Sep 25, 2022 •

edited

Loading