Skip to content

[Backport 2.x] [Segment Replication ] Add shard routing primary check when processing a checkpoint.#4716

Merged
dreamer-89 merged 1 commit intoopensearch-project:2.xfrom
Rishikesh1159:primary-checking
Oct 10, 2022
Merged

[Backport 2.x] [Segment Replication ] Add shard routing primary check when processing a checkpoint.#4716
dreamer-89 merged 1 commit intoopensearch-project:2.xfrom
Rishikesh1159:primary-checking

Conversation

@Rishikesh1159
Copy link
Copy Markdown
Member

Signed-off-by: Rishikesh1159 rishireddy1159@gmail.com

Description

This PR backports #4630

Issues Resolved

#3923

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@Rishikesh1159 Rishikesh1159 requested review from a team and reta as code owners October 10, 2022 02:58
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4716 (0e8cf3e) into 2.x (a90fd73) will increase coverage by 0.06%.
The diff coverage is 66.88%.

@@             Coverage Diff              @@
##                2.x    #4716      +/-   ##
============================================
+ Coverage     70.62%   70.68%   +0.06%     
- Complexity    57126    57486     +360     
============================================
  Files          4585     4615      +30     
  Lines        274526   275861    +1335     
  Branches      40233    40363     +130     
============================================
+ Hits         193876   194994    +1118     
- Misses        64403    64691     +288     
+ Partials      16247    16176      -71     
Impacted Files Coverage Δ
...ava/org/opensearch/client/RestHighLevelClient.java 41.75% <0.00%> (-2.27%) ⬇️
...er/src/main/java/org/opensearch/client/Client.java 40.00% <ø> (ø)
.../org/opensearch/client/support/AbstractClient.java 34.25% <0.00%> (-0.45%) ⬇️
...main/java/org/opensearch/common/lucene/Lucene.java 66.66% <ø> (+0.84%) ⬆️
...rg/opensearch/common/settings/ClusterSettings.java 91.89% <ø> (ø)
...pensearch/common/settings/IndexScopedSettings.java 100.00% <ø> (ø)
...index/codec/PerFieldMappingPostingFormatCodec.java 64.28% <ø> (ø)
...rg/opensearch/index/engine/TranslogLeafReader.java 40.90% <ø> (ø)
...java/org/opensearch/index/get/ShardGetService.java 60.89% <ø> (ø)
...nsearch/rest/action/cat/RestPitSegmentsAction.java 8.88% <8.88%> (ø)
... and 566 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

- [Segment Replication] Fix NoSuchFileExceptions with segment replication when computing primary metadata snapshots ([#4366](https://github.com/opensearch-project/OpenSearch/pull/4366))
- [Segment Replication] Fix timeout issue by calculating time needed to process getSegmentFiles ([#4434](https://github.com/opensearch-project/OpenSearch/pull/4434))
- [Segment Replication] Update replicas to commit SegmentInfos instead of relying on segments_N from primary shards.
- [Segment Replication] Update replicas to commit SegmentInfos instead of relying on segments_N from primary shards ([#4450](https://github.com/opensearch-project/OpenSearch/pull/4450))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this changelog entry.

@dreamer-89 dreamer-89 merged commit a4b990d into opensearch-project:2.x Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants