[Feature/extensions] Add contentParser method to ExtensionRestRequest#4760
Merged
owaiskazi19 merged 1 commit intoopensearch-project:feature/extensionsfrom Oct 13, 2022
Merged
Conversation
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## feature/extensions #4760 +/- ##
========================================================
- Coverage 70.71% 70.66% -0.06%
+ Complexity 57896 57884 -12
========================================================
Files 4706 4706
Lines 277831 277834 +3
Branches 40389 40389
========================================================
- Hits 196481 196330 -151
- Misses 65114 65250 +136
- Partials 16236 16254 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
owaiskazi19
approved these changes
Oct 13, 2022
joshpalis
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Widdis widdis@gmail.com
Companion PR: opensearch-project/opensearch-sdk-java#192
This PR does not change the API and can be merged at any time before the companion PR even if it is still in review.
Description
Adds a
contentParser()method to theExtensionRestRequestclass to enable extensions to parse REST requests with bodies containing JSON, SMILE, YAML, or CBOR.Issues Resolved
OpenSearch part of SDK #178
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.