Add groupId value propagation tests for ZIP publication task#4772
Merged
reta merged 1 commit intoopensearch-project:mainfrom Oct 19, 2022
Merged
Add groupId value propagation tests for ZIP publication task#4772reta merged 1 commit intoopensearch-project:mainfrom
reta merged 1 commit intoopensearch-project:mainfrom
Conversation
a356d8d to
9bc7589
Compare
6 tasks
Contributor
Gradle Check (Jenkins) Run Completed with:
|
9bc7589 to
505a1fa
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
Oct 13, 2022
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Author
|
Hmm... Flaky tests again? (Timing out...) |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4772 +/- ##
============================================
+ Coverage 70.66% 70.72% +0.06%
- Complexity 57578 57636 +58
============================================
Files 4661 4669 +8
Lines 276662 276863 +201
Branches 40325 40346 +21
============================================
+ Hits 195501 195821 +320
+ Misses 64926 64713 -213
- Partials 16235 16329 +94
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
505a1fa to
be0cb20
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
prudhvigodithi
approved these changes
Oct 14, 2022
buildSrc/src/test/java/org/opensearch/gradle/pluginzip/PublishTests.java
Show resolved
Hide resolved
The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases. - In one case the groupId is inherited from the top most 'allprojects' section (and thus can be missing in the publications section). - The other case is opposite, it tests that if the groupId is defined on several levels then the most internal level outweighs the other levels. Closes: opensearch-project#4771 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
be0cb20 to
5f6e041
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
prudhvigodithi
approved these changes
Oct 19, 2022
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4772-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eb3301554ec7e1a07866508ffc390b8651dc3394
# Push it to GitHub
git push --set-upstream origin backport/backport-4772-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
lukas-vlcek
added a commit
to lukas-vlcek/OpenSearch
that referenced
this pull request
Oct 20, 2022
This is back-port of opensearch-project#4772 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> (cherry picked from commit eb33015)
6 tasks
Contributor
Author
|
I fixed the back-port PR manually (Resolved conflicts) and prepared a new PR here #4848 I do not think I can do so I did |
lukas-vlcek
added a commit
to lukas-vlcek/OpenSearch
that referenced
this pull request
Oct 20, 2022
This is back-port of opensearch-project#4772 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> (cherry picked from commit eb33015)
lukas-vlcek
added a commit
to lukas-vlcek/OpenSearch
that referenced
this pull request
Oct 21, 2022
This is back-port of opensearch-project#4772 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> (cherry picked from commit eb33015)
reta
pushed a commit
that referenced
this pull request
Oct 21, 2022
ashking94
pushed a commit
to ashking94/OpenSearch
that referenced
this pull request
Nov 7, 2022
…rch-project#4772) The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases. - In one case the groupId is inherited from the top most 'allprojects' section (and thus can be missing in the publications section). - The other case is opposite, it tests that if the groupId is defined on several levels then the most internal level outweighs the other levels. Closes: opensearch-project#4771 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases.
allprojectssection (and thus can be missing in the publications section).Issues Resolved
Closes: #4771
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Lukáš Vlček lukas.vlcek@aiven.io