[Remove] LegacyESVersion.V_7_6_* and V_7_7_* constants#4837
Merged
nknize merged 5 commits intoNov 1, 2022
Conversation
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Author
|
Oh fun! Looks like we have a race condition in
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4837 +/- ##
============================================
+ Coverage 70.87% 70.90% +0.03%
+ Complexity 57922 57884 -38
============================================
Files 4692 4692
Lines 276852 276648 -204
Branches 40236 40157 -79
============================================
- Hits 196212 196151 -61
+ Misses 64458 64314 -144
- Partials 16182 16183 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dblock
approved these changes
Oct 20, 2022
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
|
I believe this has been fixed in #4270, rebase? |
a317763 to
6bfadbb
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Removes all usages of LegacyESVersion.V_7_6_ and LegacyESVersion.V_7_7_ version constants along with ancient API logic. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
6bfadbb to
1f533a0
Compare
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all usages of LegacyESVersion.V_7_6_ and LegacyESVersion.V_7_7_ version constants along with ancient API logic.
relates #2747