Update pull request template to include tips#4851
Merged
adnapibar merged 2 commits intoopensearch-project:mainfrom Oct 21, 2022
adnapibar:pr-template-update
Merged
Update pull request template to include tips#4851adnapibar merged 2 commits intoopensearch-project:mainfrom adnapibar:pr-template-update
adnapibar merged 2 commits intoopensearch-project:mainfrom
adnapibar:pr-template-update
Conversation
Contributor
Gradle Check (Jenkins) Run Completed with:
|
andrross
reviewed
Oct 20, 2022
| @@ -1,3 +1,10 @@ | |||
| <!-- Thanks for sending a pull request, here are some tips: | |||
Member
There was a problem hiding this comment.
Does the <!-- comment syntax mean this text is only visible to a user while editing the PR description?
Contributor
Author
There was a problem hiding this comment.
Yes, it is not visible during the markdown rendering
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4851 +/- ##
============================================
+ Coverage 70.70% 70.82% +0.11%
- Complexity 57852 57912 +60
============================================
Files 4689 4689
Lines 277080 277080
Branches 40302 40302
============================================
+ Hits 195917 196236 +319
+ Misses 64935 64592 -343
- Partials 16228 16252 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
|
I believe this has been fixed in #4270, rebase? |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
andrross
approved these changes
Oct 21, 2022
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
snuyanzin
pushed a commit
to snuyanzin/OpenSearch
that referenced
this pull request
Oct 28, 2022
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
ashking94
pushed a commit
to ashking94/OpenSearch
that referenced
this pull request
Nov 7, 2022
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rabi Panda adnapibar@gmail.com
Description
Add commented tips in pull request template
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.