Skip to content

Add a link to the flakey test dev guide.#4872

Merged
dblock merged 3 commits intoopensearch-project:mainfrom
dblock:flakey-test-box
Oct 24, 2022
Merged

Add a link to the flakey test dev guide.#4872
dblock merged 3 commits intoopensearch-project:mainfrom
dblock:flakey-test-box

Conversation

@dblock
Copy link
Copy Markdown
Member

@dblock dblock commented Oct 21, 2022

Signed-off-by: Daniel (dB.) Doubrovkine dblock@amazon.com

Description

Added some text to help the contributor with next steps on CI failures.

Issues Resolved

Closes #4871.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested review from a team and reta as code owners October 21, 2022 17:52
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 21, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.86%. Comparing base (2310a3d) to head (1cf766c).
⚠️ Report is 4545 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4872      +/-   ##
============================================
+ Coverage     70.83%   70.86%   +0.03%     
- Complexity    57884    57946      +62     
============================================
  Files          4689     4689              
  Lines        276913   276913              
  Branches      40301    40301              
============================================
+ Hits         196141   196247     +106     
+ Misses        64499    64430      -69     
+ Partials      16273    16236      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Copy Markdown
Member Author

dblock commented Oct 24, 2022

org.opensearch.repositories.s3.RepositoryS3ClientYamlTestSuiteIT > test {yaml=repository_s3/20_repository_permanent_credentials/Snapshot and Restore with repository-s3 using permanent credentials} FAILED
    java.lang.AssertionError: Failure at [repository_s3/20_repository_permanent_credentials:152]: expected [2xx] status code but api [snapshot.create] returned [400 Bad Request] [{"error":{"root_cause":[{"type":"invalid_snapshot_name_exception","reason":"[repository_permanent:snapshot-one] Invalid snapshot name [snapshot-one], snapshot with the same name already exists","stack_trace":"InvalidSnapshotNameException[[rep

#2064

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Copy Markdown
Member Author

dblock commented Oct 24, 2022

Again

 - org.opensearch.repositories.s3.RepositoryS3ClientYamlTestSuiteIT.test {yaml=repository_s3/20_repository_permanent_credentials/Try to create repository with broken endpoint override and named client}

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock dblock merged commit 67a29df into opensearch-project:main Oct 24, 2022
@dblock dblock added the backport 2.x Backport to 2.x branch label Oct 24, 2022
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4872-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 67a29dff7a1f72abf7295360bd541d1cd0155f73
# Push it to GitHub
git push --set-upstream origin backport/backport-4872-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4872-to-2.x.

@peterzhuamazon
Copy link
Copy Markdown
Member

@dblock please add this to 1.x and 1.3 as well.

Thanks.

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-4872-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 67a29dff7a1f72abf7295360bd541d1cd0155f73
# Push it to GitHub
git push --set-upstream origin backport/backport-4872-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-4872-to-1.x.

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-4872-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 67a29dff7a1f72abf7295360bd541d1cd0155f73
# Push it to GitHub
git push --set-upstream origin backport/backport-4872-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-4872-to-1.3.

@dblock
Copy link
Copy Markdown
Member Author

dblock commented Oct 25, 2022

@dblock please add this to 1.x and 1.3 as well.

Thanks.

Will do. I think I want to edit this a bit on main first.

@dblock dblock deleted the flakey-test-box branch October 25, 2022 14:30
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Nov 7, 2022
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>

Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.x backport 1.3 Backport to 1.3 branch backport 2.x Backport to 2.x branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CI failure note to include a link to DEVELOPER_GUIDE

4 participants