Remove unused private methods#4926
Merged
reta merged 2 commits intoopensearch-project:mainfrom Oct 27, 2022
Merged
Conversation
Signed-off-by: Sergey Nuyanzin <snuyanzin@gmail.com>
Signed-off-by: Sergey Nuyanzin <snuyanzin@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4926 +/- ##
============================================
+ Coverage 70.78% 70.81% +0.02%
+ Complexity 57906 57901 -5
============================================
Files 4689 4689
Lines 276991 276914 -77
Branches 40311 40302 -9
============================================
+ Hits 196074 196097 +23
+ Misses 64677 64583 -94
+ Partials 16240 16234 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dblock
approved these changes
Oct 26, 2022
Member
|
@nknize Any underwater mines you know of with this? |
nknize
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I realised there is a bunch of private/package private unused methods...
Since they are private and unused this is a PR to remove them
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.