Fix for failing checkExtraction, checkLicense and checkNotice tasks for windows gradle check#4941
Merged
dblock merged 2 commits intoopensearch-project:mainfrom Oct 27, 2022
Conversation
Contributor
Gradle Check (Jenkins) Run Completed with:
|
5035ff2 to
207a2df
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
|
Think you need a rebase after - #4922 was merged. |
207a2df to
733caec
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
733caec to
0d80067
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
vibrantvarun
approved these changes
Oct 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #4941 +/- ##
============================================
+ Coverage 70.81% 70.84% +0.03%
- Complexity 57907 57954 +47
============================================
Files 4688 4688
Lines 276893 276895 +2
Branches 40298 40298
============================================
+ Hits 196083 196178 +95
+ Misses 64548 64493 -55
+ Partials 16262 16224 -38
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joshpalis
approved these changes
Oct 27, 2022
dblock
approved these changes
Oct 27, 2022
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4941-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6e90080a330278bec3c109825240dd8c327e961c
# Push it to GitHub
git push --set-upstream origin backport/backport-4941-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
Member
|
@joshpalis Manual backport to 2.x? |
6 tasks
Poojita-Raj
added a commit
to Poojita-Raj/OpenSearch
that referenced
this pull request
Oct 27, 2022
…or windows gradle check (opensearch-project#4941) * Fix for failing checkExtraction and checkLicense tasks Signed-off-by: Poojita Raj <poojiraj@amazon.com> * changelog added Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com>
saratvemulapalli
pushed a commit
that referenced
this pull request
Oct 28, 2022
…or windows gradle check (#4941) (#4961) * Fix for failing checkExtraction and checkLicense tasks Signed-off-by: Poojita Raj <poojiraj@amazon.com> * changelog added Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Poojita-Raj
added a commit
to Poojita-Raj/OpenSearch
that referenced
this pull request
Nov 8, 2022
…or windows gradle check (opensearch-project#4941) * Fix for failing checkExtraction and checkLicense tasks Signed-off-by: Poojita Raj <poojiraj@amazon.com> * changelog added Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Merged
6 tasks
Poojita-Raj
added a commit
to Poojita-Raj/OpenSearch
that referenced
this pull request
Nov 8, 2022
…or windows gradle check (opensearch-project#4941) * Fix for failing checkExtraction and checkLicense tasks Signed-off-by: Poojita Raj <poojiraj@amazon.com> * changelog added Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com>
dblock
pushed a commit
that referenced
this pull request
Nov 8, 2022
…or windows gradle check (#4941) (#5119) * Fix for failing checkExtraction and checkLicense tasks Signed-off-by: Poojita Raj <poojiraj@amazon.com> * changelog added Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-4941-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6e90080a330278bec3c109825240dd8c327e961c
# Push it to GitHub
git push --set-upstream origin backport/backport-4941-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.xThen, create a pull request where the |
Poojita-Raj
added a commit
to Poojita-Raj/OpenSearch
that referenced
this pull request
Nov 17, 2022
…kNotice tasks for windows gradle check (opensearch-project#4941) Signed-off-by: Poojita Raj <poojiraj@amazon.com>
This was referenced Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Poojita Raj poojiraj@amazon.com
Description
This is a fix for failing windows gradle check tasks as part of providing windows CI support. This focuses on 3 groups of failing tasks - checkExtraction, checkLicense and checkNotice tasks.
Issues Resolved
Resolves #4925, #4939, #4940
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.