Remove PRRL creation/deletion in peer recovery of remote store enabled replica by ashking94 · Pull Request #4954 · opensearch-project/OpenSearch

ashking94 · 2022-10-27T08:32:24Z

Description

PRRL is used to keep lucene operation history and is also used in recovery for replaying these operations once the segment files are sent to the target. During replica recovery, PRRL is acquired for sending these operations to the replica after the segment files (from most recent safe commit) are copied over to replicas. This is not required when remote translog is enabled. This PR aims to remove the unnecessary code around PRRL in case of recovery of remote store enabled replicas.

Issues Resolved

#4502

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2022-10-27T08:34:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5767/
CommitID: 0a11740
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-10-27T09:04:52Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5768/
CommitID: 472fc70
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-10-27T09:45:54Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5771/
CommitID: 6f88c46
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-10-27T09:53:09Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5772/
CommitID: 79c1d1a

codecov-commenter · 2022-10-27T09:54:07Z

Codecov Report

Merging #4954 (9e5eb24) into main (0eb6b2f) will increase coverage by 0.00%.
The diff coverage is 84.69%.

@@            Coverage Diff            @@
##               main    #4954   +/-   ##
=========================================
  Coverage     70.87%   70.88%           
+ Complexity    58105    58071   -34     
=========================================
  Files          4708     4711    +3     
  Lines        277559   277604   +45     
  Branches      40189    40190    +1     
=========================================
+ Hits         196729   196780   +51     
+ Misses        64722    64690   -32     
- Partials      16108    16134   +26

Impacted Files	Coverage Δ
...overy/RemoteStoreReplicaRecoverySourceHandler.java	`77.77% <77.77%> (ø)`
...indices/recovery/DefaultRecoverySourceHandler.java	`80.68% <80.68%> (ø)`
...search/indices/recovery/RecoverySourceHandler.java	`77.96% <90.90%> (-0.16%)`	⬇️
...org/opensearch/index/seqno/ReplicationTracker.java	`68.70% <100.00%> (+0.34%)`	⬆️
...ch/indices/recovery/PeerRecoverySourceService.java	`60.00% <100.00%> (+3.67%)`	⬆️
...indices/recovery/RecoverySourceHandlerFactory.java	`100.00% <100.00%> (ø)`
...org/opensearch/index/shard/IndexShardTestCase.java	`94.02% <100.00%> (+0.07%)`	⬆️
...g/opensearch/index/analysis/CharFilterFactory.java	`0.00% <0.00%> (-100.00%)`	⬇️
.../java/org/opensearch/node/NodeClosedException.java	`50.00% <0.00%> (-50.00%)`	⬇️
.../opensearch/client/indices/CloseIndexResponse.java	`56.25% <0.00%> (-35.00%)`	⬇️
... and 501 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-10-27T11:49:22Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5783/
CommitID: d69f770
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-10-27T16:11:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5791/
CommitID: e6cd4a9
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-10-27T16:28:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5792/
CommitID: 77d0d3d

ashking94 · 2022-10-27T16:51:24Z

@Bukhtawar @sachinpkale Can you take a look at this?

gbbafna · 2022-11-02T06:30:18Z

Changes look good to me .

Few clarifying questions :

How did we test out these changes ? Will we do end to end testing later ?
What is the impact of not removing PRRL for primary's recovery ? I do understand we do need PRRL for primary. Trying to understand the end goal here .

ashking94 · 2022-11-02T17:33:39Z

@gbbafna thanks for the review -

How did we test out these changes ? Will we do end to end testing later ?

There are units tests (OpenSearchTestCase) - ReplicaRecoveryWithRemoteTranslogOnPrimaryTests. Apart from that, validated the same by running the recovery with tweaking some changes locally. There would be more IT tests added once we have remote translog changes merged.

What is the impact of not removing PRRL for primary's recovery ? I do understand we do need PRRL for primary. Trying to understand the end goal here.

PRRL would still be used for doing primary-primary peer recovery. PRRL helps in doing sequence based recovery by replaying the same lucene operations on the recovering replica (which would be bumped to primary).

sachinpkale · 2022-11-03T13:22:43Z

server/src/main/java/org/opensearch/indices/recovery/PeerRecoverySourceService.java


        private final class ShardRecoveryContext {
            final Map<RecoverySourceHandler, RemoteRecoveryTargetHandler> recoveryHandlers = new HashMap<>();
+            private final RecoverySourceHandlerFactory recoverySourceHandlerFactory = new RecoverySourceHandlerFactory();


nit: This can be a singleton.

Java does not allow creating static fields within inner classes. It's supported, I guess, from 16/17+.

Why is the factory an instance at all? It contains no state. I think you can make RecoverySourceHandlerFactory#create static and call it below without creating an instance.

sachinpkale · 2022-11-03T13:26:24Z

server/src/main/java/org/opensearch/indices/recovery/RecoverySourceHandlerFactory.java

+        StartRecoveryRequest request,
+        RecoverySettings recoverySettings
+    ) {
+        boolean isReplicaRecoveryWithRemoteTranslog = request.isPrimaryRelocation() == false && shard.isRemoteTranslogEnabled();


Why are we checking request.isPrimaryRelocation() == false?

request.isPrimaryRelocation() == false is replica recovery. We want to use the RemoteStoreReplicaRecoverySourceHandler only for recovering the replicas. When request.isPrimaryRelocation() == true, it is primary-primary recovery for which it would be DefaultRecoverySourceHandler. Primary-primary recovery would involve translogs and lucene operation replay during the peer recovery.

sachinpkale · 2022-11-03T13:31:22Z

server/src/test/java/org/opensearch/indices/recovery/RecoverySourceHandlerTests.java

            }
        };
-        RecoverySourceHandler handler = new RecoverySourceHandler(
+        RecoverySourceHandler handler = new DefaultRecoverySourceHandler(


These tests essentially become tests for DefaultRecoverySourceHandler. Don't we need tests for RemoteStoreReplicaRecoverySourceHandler as well?

The RecoverySourceHandlerTests now covers both the RecoverySourceHandler and DefaultRecoverySourceHandler. The tests for RemoteStoreReplicaRecoverySourceHandler were written in an older PR and is present in ReplicaRecoveryWithRemoteTranslogOnPrimaryTests.java. Let me decompose it and create another test class dedicated to the new Handler.

ashking94 · 2022-11-07T06:08:20Z

server/src/main/java/org/opensearch/index/seqno/ReplicationTracker.java

            // all tracked shard copies have a corresponding peer-recovery retention lease
            for (final ShardRouting shardRouting : routingTable.assignedShards()) {
-                if (checkpoints.get(shardRouting.allocationId().getId()).tracked) {
+                if (checkpoints.get(shardRouting.allocationId().getId()).tracked && !indexSettings().isRemoteTranslogStoreEnabled()) {


This is required as currently if a shard is tracked then it is expected to have a corresponding retention lease.

github-actions · 2022-11-07T06:48:44Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6427/
CommitID: 561d668
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-07T07:01:24Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6428/
CommitID: 5146fdc
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-07T07:54:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6429/
CommitID: 13ab532

Signed-off-by: Ashish Singh <ssashish@amazon.com>

github-actions · 2022-11-14T14:01:23Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6864/
CommitID: 7842788

andrross

Looks good, mostly minor comments

andrross · 2022-11-15T23:39:26Z

server/src/main/java/org/opensearch/indices/recovery/RecoverySourceHandler.java

 * @opensearch.internal
 */
-public class RecoverySourceHandler {
+public abstract class RecoverySourceHandler {


Can you make the constructor package-private to prevent this from being extended in ways not intended? I'm assuming this should only ever be instantiated via one of the subclasses in this package.

andrross · 2022-11-15T23:43:05Z

server/src/main/java/org/opensearch/indices/recovery/RecoverySourceHandlerFactory.java

+import org.opensearch.index.shard.IndexShard;
+
+/**
+ * Factory that supplies {@link RecoverySourceHandler}.


Please add @opensearch.internal

andrross · 2022-11-15T23:43:12Z

...r/src/main/java/org/opensearch/indices/recovery/RemoteStoreReplicaRecoverySourceHandler.java

+import java.util.function.Consumer;
+
+/**
+ * This handler is used when peer recovery target is a remote store enabled replica.


Please add @opensearch.internal

andrross · 2022-11-15T23:43:23Z

server/src/main/java/org/opensearch/indices/recovery/DefaultRecoverySourceHandler.java

+
+/**
+ * This handler is used for the peer recovery when there is no remote store available for segments/translogs. TODO -
+ * Add more details as this is refactored further.


Please add @opensearch.internal

andrross · 2022-11-15T23:46:05Z

server/src/main/java/org/opensearch/indices/recovery/PeerRecoverySourceService.java


        private final class ShardRecoveryContext {
            final Map<RecoverySourceHandler, RemoteRecoveryTargetHandler> recoveryHandlers = new HashMap<>();
+            private final RecoverySourceHandlerFactory recoverySourceHandlerFactory = new RecoverySourceHandlerFactory();


Why is the factory an instance at all? It contains no state. I think you can make RecoverySourceHandlerFactory#create static and call it below without creating an instance.

andrross · 2022-11-16T00:21:50Z

server/src/main/java/org/opensearch/indices/recovery/DefaultRecoverySourceHandler.java

+import java.util.function.Consumer;
+
+/**
+ * This handler is used for the peer recovery when there is no remote store available for segments/translogs. TODO -


It is probably better to document this based on what it is/what it does, versus what it is not. e.g. "this handler is used for node-to-node recovery..."

It might also be better to give it a name more descriptive that "default". "Default" makes sense when you are adding a new alternative but will be less obvious over time. Maybe something like "RetentionLeaseRecoverySourceHandler" or "LocalRecoverySourceHandler"?

Makes sense. Will make the change.

andrross · 2022-11-16T00:29:09Z

...r/src/main/java/org/opensearch/indices/recovery/RemoteStoreReplicaRecoverySourceHandler.java

+    @Override
+    protected void innerRecoveryToTarget(ActionListener<RecoveryResponse> listener, Consumer<Exception> onFailure) throws IOException {
+        // A replica of an index with remote translog does not require the translogs locally and keeps receiving the
+        // updated segments file on refresh, flushes, and merges. We plan to make the existing replication call to


The "We plan to" comment is confusing here. It suggests something here needs to change in the future. Are these sentences needed beyond the first sentence that says a local translog isn't needed?

Yes, the "we plan to" comment tells us what is coming as this is an incremental PR to the bigger effort. However, I get that we can make it shorter and concise. I have reworded the "we plan to" section. Let me know if this makes sense.

The update looks good, thanks!

I know this is nit-picky but comments like "we plan to..." very often become stale and will still be present in the code even after all the planned work is done, because the future work may not touch this exact piece of code again. So unless there is a strong need to document future intent I find it is better to try to avoid it.

Signed-off-by: Ashish Singh <ssashish@amazon.com>

github-actions · 2022-11-16T15:07:22Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6964/
CommitID: 3e5e2ee

andrross · 2022-11-16T20:01:23Z

@ashking94 Should this be backported to 2.x? I've added the label but want to get confirmation from you.

opensearch-trigger-bot · 2022-11-16T20:02:34Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4954-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0be3afbd249f771057663059279b4d02e4d282df
# Push it to GitHub
git push --set-upstream origin backport/backport-4954-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4954-to-2.x.

ashking94 · 2022-11-17T05:36:26Z

@ashking94 Should this be backported to 2.x? I've added the label but want to get confirmation from you.

Yes, the plan is to get request level durability in 2.5 for which this is an incremental step.

ashking94 · 2022-11-17T05:36:49Z

Thanks for the review, @andrross, @sachinpkale & @gbbafna!

andrross · 2022-11-17T17:19:35Z

@ashking94 Auto-backport failed. Can you go ahead and create the backport PR?

…d replica (opensearch-project#4954) * Add RecoverySourceHandlerFactory for extensibility Signed-off-by: Ashish Singh <ssashish@amazon.com> * recoverToTarget made extensible to allow multiple implementations Signed-off-by: Ashish Singh <ssashish@amazon.com> * Remove PRRL after SendFileStep in Peer Recovery Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Remove CHANGELOG entry as this is incremental PR Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com>

…5731) * Remove PRRL creation/deletion in peer recovery of remote store enabled replica (#4954) * Add RecoverySourceHandlerFactory for extensibility Signed-off-by: Ashish Singh <ssashish@amazon.com> * recoverToTarget made extensible to allow multiple implementations Signed-off-by: Ashish Singh <ssashish@amazon.com> * Remove PRRL after SendFileStep in Peer Recovery Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Remove CHANGELOG entry as this is incremental PR Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Enhance CheckpointState to support no-op replication (#5282) * CheckpointState enhanced to support no-op replication Signed-off-by: Ashish Singh <ssashish@amazon.com> Co-authored-by: Bukhtawar Khan<bukhtawa@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Add transport action for primary term validation for remote-backed indices (#5616) Add transport action for primary term validation for remote-backed indices Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com>

…pensearch-project#5731) * Remove PRRL creation/deletion in peer recovery of remote store enabled replica (opensearch-project#4954) * Add RecoverySourceHandlerFactory for extensibility Signed-off-by: Ashish Singh <ssashish@amazon.com> * recoverToTarget made extensible to allow multiple implementations Signed-off-by: Ashish Singh <ssashish@amazon.com> * Remove PRRL after SendFileStep in Peer Recovery Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Remove CHANGELOG entry as this is incremental PR Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Enhance CheckpointState to support no-op replication (opensearch-project#5282) * CheckpointState enhanced to support no-op replication Signed-off-by: Ashish Singh <ssashish@amazon.com> Co-authored-by: Bukhtawar Khan<bukhtawa@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Add transport action for primary term validation for remote-backed indices (opensearch-project#5616) Add transport action for primary term validation for remote-backed indices Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Remove PRRL creation/deletion in peer recovery of remote store enabled replica (#4954) * Add RecoverySourceHandlerFactory for extensibility Signed-off-by: Ashish Singh <ssashish@amazon.com> * recoverToTarget made extensible to allow multiple implementations Signed-off-by: Ashish Singh <ssashish@amazon.com> * Remove PRRL after SendFileStep in Peer Recovery Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Remove CHANGELOG entry as this is incremental PR Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Enhance CheckpointState to support no-op replication (#5282) * CheckpointState enhanced to support no-op replication Signed-off-by: Ashish Singh <ssashish@amazon.com> Co-authored-by: Bukhtawar Khan<bukhtawa@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Add transport action for primary term validation for remote-backed indices (#5616) Add transport action for primary term validation for remote-backed indices Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> Co-authored-by: Ashish <ssashish@amazon.com>

…5731) * Remove PRRL creation/deletion in peer recovery of remote store enabled replica (#4954) * Add RecoverySourceHandlerFactory for extensibility Signed-off-by: Ashish Singh <ssashish@amazon.com> * recoverToTarget made extensible to allow multiple implementations Signed-off-by: Ashish Singh <ssashish@amazon.com> * Remove PRRL after SendFileStep in Peer Recovery Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> * Remove CHANGELOG entry as this is incremental PR Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review feedback Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Enhance CheckpointState to support no-op replication (#5282) * CheckpointState enhanced to support no-op replication Signed-off-by: Ashish Singh <ssashish@amazon.com> Co-authored-by: Bukhtawar Khan<bukhtawa@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> * Add transport action for primary term validation for remote-backed indices (#5616) Add transport action for primary term validation for remote-backed indices Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com>

ashking94 force-pushed the 4502-1 branch from 0a11740 to 472fc70 Compare October 27, 2022 08:33

ashking94 changed the title ~~Add RecoverySourceHandlerFactory for extensibility~~ Remove PRRL creation/deletion in replica peer recovery Oct 27, 2022

ashking94 force-pushed the 4502-1 branch 2 times, most recently from 6f88c46 to 79c1d1a Compare October 27, 2022 09:19

ashking94 changed the title ~~Remove PRRL creation/deletion in replica peer recovery~~ Remove PRRL creation/deletion in peer recovery of remote store enabled replica Oct 27, 2022

ashking94 force-pushed the 4502-1 branch 2 times, most recently from e6cd4a9 to 77d0d3d Compare October 27, 2022 15:57

ashking94 marked this pull request as ready for review October 27, 2022 15:57

ashking94 requested review from a team and reta as code owners October 27, 2022 15:57

sachinpkale reviewed Nov 3, 2022

View reviewed changes

ashking94 commented Nov 7, 2022

View reviewed changes

ashking94 force-pushed the 4502-1 branch 2 times, most recently from 561d668 to 5146fdc Compare November 7, 2022 06:37

ashking94 requested a review from sachinpkale November 7, 2022 06:37

ashking94 force-pushed the 4502-1 branch from 5146fdc to 13ab532 Compare November 7, 2022 07:24

ashking94 added 4 commits November 14, 2022 19:00

Incorporate PR review feedback

72cec63

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Empty-Commit

02ccd9a

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Empty-Commit

03a2f18

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Remove CHANGELOG entry as this is incremental PR

7842788

Signed-off-by: Ashish Singh <ssashish@amazon.com>

ashking94 force-pushed the 4502-1 branch from 7246643 to 7842788 Compare November 14, 2022 13:30

ashking94 requested a review from Bukhtawar November 15, 2022 08:50

andrross reviewed Nov 16, 2022

View reviewed changes

Incorporate PR review feedback

3e5e2ee

Signed-off-by: Ashish Singh <ssashish@amazon.com>

ashking94 requested a review from andrross November 16, 2022 14:37

andrross approved these changes Nov 16, 2022

View reviewed changes

andrross merged commit 0be3afb into opensearch-project:main Nov 16, 2022

andrross added the backport 2.x Backport to 2.x branch label Nov 16, 2022

ashking94 mentioned this pull request Dec 26, 2022

Add transport action for primary term validation for remote-backed indices #5616

Merged

6 tasks

Bukhtawar mentioned this pull request Dec 31, 2022

Adding @gbbafna to OpenSearch maintainers #5668

Merged

2 tasks

This was referenced Jan 6, 2023

[Backport 2.x] Remove PRRL creation/deletion in peer recovery of remote store enabled replica (#4954) #5728

Closed

[Backport 2.x] Support no-op replication for remote-backed indexes #5731

Merged

Bukhtawar mentioned this pull request Jun 27, 2024

Add Ashish Singh as maintainer #14567

Merged

Conversation

ashking94 commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

github-actions bot commented Oct 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov-commenter commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

ashking94 commented Oct 27, 2022

Uh oh!

gbbafna commented Nov 2, 2022

Uh oh!

ashking94 commented Nov 2, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashking94 Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 7, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 7, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 7, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 14, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

andrross left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

ashking94 commented Oct 27, 2022 •

edited

Loading

codecov-commenter commented Oct 27, 2022 •

edited

Loading

ashking94 Nov 3, 2022 •

edited

Loading

andrross commented Nov 16, 2022 •

edited

Loading

ashking94 commented Nov 17, 2022 •

edited

Loading