add support for ppc64le architecture#5459
Conversation
Signed-off-by: Priya Seth <sethp@us.ibm.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5459 +/- ##
============================================
+ Coverage 70.95% 71.02% +0.07%
- Complexity 58304 58340 +36
============================================
Files 4733 4733
Lines 278256 278262 +6
Branches 40249 40249
============================================
+ Hits 197441 197649 +208
+ Misses 64628 64433 -195
+ Partials 16187 16180 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@seth-priya thank you for contributing the change. Is there a way to add a test for these changes? |
dbwiddis
left a comment
There was a problem hiding this comment.
Looks good... one fix needed (comments) and one suggestion (constants).
Agree with the question about tests -- I suspect we can at least test the enum determination by manipulating os.arch property.
| m.put("amd64", new Arch(0xC000003E, 0x3FFFFFFF, 57, 58, 59, 322, 317)); | ||
| m.put("aarch64", new Arch(0xC00000B7, 0xFFFFFFFF, 1079, 1071, 221, 281, 277)); | ||
| m.put("s390x", new Arch(0x80000016, 0xFFFFFFFF, 2, 190, 11, 354, 348)); | ||
| m.put("ppc64le", new Arch(0xC0000015, 0xFFFFFFFF, 2, 189, 11, 362, 358)); |
There was a problem hiding this comment.
(Preference) I would really like if at least some these values could be made constants. I see above they correspond to AUDIT_ARCH_XXX, __NR_xxx, etc.
|
thanks @saratvemulapalli @dbwiddis for your feedback, I will work on it and get back soon. |
Signed-off-by: Priya Seth <sethp@us.ibm.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
saratvemulapalli
left a comment
There was a problem hiding this comment.
Thanks @seth-priya , looks like inherently gradle scripts are testing the expected distributions.
|
@seth-priya could you update |
|
thanks @saratvemulapalli for the feedback and review comments , agree on the test, addressed the conflict |
Gradle Check (Jenkins) Run Completed with:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5459-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d76adf3504e3001a84d53177af8ea36af2cc65c1
# Push it to GitHub
git push --set-upstream origin backport/backport-5459-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…earch-project#6224) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Priya Seth <sethp@us.ibm.com>
Signed-off-by: Priya Seth sethp@us.ibm.com
Description
add support for ppc64le architecture
Issues Resolved
#1303
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.