[Backport 2.x] Adding support to register settings dynamically#5544
Merged
saratvemulapalli merged 1 commit into2.xfrom Dec 13, 2022
Merged
[Backport 2.x] Adding support to register settings dynamically#5544saratvemulapalli merged 1 commit into2.xfrom
saratvemulapalli merged 1 commit into2.xfrom
Conversation
* Adding support to register settings dynamically Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Update CHANGELOG Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Removed unnecessary registerSetting methods Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Change setting registration order Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Add unregisterSettings method Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Remove unnecessary feature flag Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> (cherry picked from commit 08cd06f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
adnapibar,
anasalkouz,
andrross,
dblock,
dreamer-89,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
saratvemulapalli,
setiah,
shwetathareja,
tlfeng and
xuezhou25
as code owners
reta
approved these changes
Dec 13, 2022
saratvemulapalli
added
backport
saratvemulapalli
approved these changes
Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## 2.x #5544 +/- ##
============================================
- Coverage 70.71% 70.58% -0.14%
+ Complexity 58492 58420 -72
============================================
Files 4716 4716
Lines 279676 279705 +29
Branches 40809 40819 +10
============================================
- Hits 197785 197425 -360
- Misses 65478 65821 +343
- Partials 16413 16459 +46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 08cd06f from #5495.