[Backport 2.x] Fix flaky SearchCancellationIT tests to avoid race condition#5657
Merged
Conversation
* Add waiting time to account for Thread.sleep inaccuracy Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit d248643) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
Bot
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
adnapibar,
anasalkouz,
andrross,
dblock,
dreamer-89,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
saratvemulapalli,
setiah,
shwetathareja,
tlfeng and
xuezhou25
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #5657 +/- ##
============================================
+ Coverage 70.59% 70.93% +0.33%
+ Complexity 58605 58578 -27
============================================
Files 4740 4760 +20
Lines 280514 279515 -999
Branches 40881 40348 -533
============================================
+ Hits 198019 198263 +244
+ Misses 65962 65098 -864
+ Partials 16533 16154 -379
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
andrross
approved these changes
Dec 29, 2022
kotwanikunal
pushed a commit
that referenced
this pull request
Jan 25, 2023
…5657) * Add waiting time to account for Thread.sleep inaccuracy Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit d248643) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport d248643 from #5656.