Skip to content

[Backport 2.x] Handle translog upload during primary relocation for remote-backed indexes (#5804)#6064

Merged
gbbafna merged 1 commit into
opensearch-project:2.xfrom
ashking94:2.x
Jan 30, 2023
Merged

[Backport 2.x] Handle translog upload during primary relocation for remote-backed indexes (#5804)#6064
gbbafna merged 1 commit into
opensearch-project:2.xfrom
ashking94:2.x

Conversation

@ashking94
Copy link
Copy Markdown
Member

  • Upload translog only if primaryMode is true

Signed-off-by: Ashish Singh ssashish@amazon.com

Description

Original PR - #5804
Solves #5795 & #5844.

Issues Resolved

Original PR - #5804
Solves #5795 & #5844.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…r remote-backed indexes (opensearch-project#5804)

* Upload translog only if primaryMode is true

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@ashking94 ashking94 marked this pull request as ready for review January 30, 2023 07:26
@ashking94 ashking94 changed the title [Remote Translog] Handle translog upload during primary relocation for remote-backed indexes (#5804) [Backport 2.x] Handle translog upload during primary relocation for remote-backed indexes (#5804) Jan 30, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 30, 2023

Codecov Report

❌ Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.43%. Comparing base (579f1a6) to head (83926d0).
⚠️ Report is 2509 commits behind head on 2.x.

Files with missing lines Patch % Lines
...in/java/org/opensearch/index/shard/IndexShard.java 58.33% 3 Missing and 2 partials ⚠️
...n/java/org/opensearch/index/engine/NoOpEngine.java 50.00% 1 Missing ⚠️
...va/org/opensearch/index/engine/ReadOnlyEngine.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #6064      +/-   ##
============================================
+ Coverage     70.37%   70.43%   +0.06%     
- Complexity    58890    58932      +42     
============================================
  Files          4769     4769              
  Lines        282621   282643      +22     
  Branches      41169    41171       +2     
============================================
+ Hits         198899   199087     +188     
+ Misses        67063    66925     -138     
+ Partials      16659    16631      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbbafna gbbafna merged commit 13bfdd6 into opensearch-project:2.x Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants