Skip to content

[Backport 2.x] Batch translog sync/upload per x ms for remote-backed indexes (#5854)#6066

Merged
gbbafna merged 2 commits intoopensearch-project:2.xfrom
ashking94:2.x
Jan 30, 2023
Merged

[Backport 2.x] Batch translog sync/upload per x ms for remote-backed indexes (#5854)#6066
gbbafna merged 2 commits intoopensearch-project:2.xfrom
ashking94:2.x

Conversation

@ashking94
Copy link
Copy Markdown
Member

  • Batch translog upload per x ms to allow high index throughput

Signed-off-by: Ashish Singh ssashish@amazon.com
Co-authored-by: Ashwin Pankaj appankaj@amazon.com
Co-authored-by: Laxman Muttineni muttil@amazon.com
Signed-off-by: Ashish Singh ssashish@amazon.com

Description

Original PR - #5854

Issues Resolved

This solves #5692

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

…arch-project#5854)

* Batch translog upload per x ms to allow high index throughput

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Ashwin Pankaj <appankaj@amazon.com>
Co-authored-by: Laxman Muttineni <muttil@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #6066 (b9a1bda) into 2.x (348852f) will decrease coverage by 0.01%.
The diff coverage is 73.88%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6066      +/-   ##
============================================
- Coverage     70.49%   70.48%   -0.01%     
- Complexity    58937    58962      +25     
============================================
  Files          4769     4770       +1     
  Lines        282601   282712     +111     
  Branches      41165    41175      +10     
============================================
+ Hits         199217   199274      +57     
+ Misses        66723    66707      -16     
- Partials      16661    16731      +70     
Impacted Files Coverage Δ
...in/cluster/health/ClusterHealthRequestBuilder.java 27.77% <0.00%> (-1.64%) ⬇️
...g/opensearch/cluster/coordination/Coordinator.java 75.96% <ø> (-3.37%) ⬇️
...ster/decommission/NodeDecommissionedException.java 40.00% <0.00%> (-10.00%) ⬇️
...pensearch/common/settings/IndexScopedSettings.java 100.00% <ø> (ø)
...search/index/translog/InternalTranslogFactory.java 100.00% <ø> (ø)
...anslog/RemoteBlobStoreInternalTranslogFactory.java 75.00% <ø> (ø)
...earch/index/translog/WriteOnlyTranslogManager.java 40.00% <ø> (ø)
...n/cluster/health/TransportClusterHealthAction.java 45.26% <20.00%> (-0.69%) ⬇️
...n/java/org/opensearch/index/engine/NoOpEngine.java 60.37% <50.00%> (+0.37%) ⬆️
...va/org/opensearch/index/engine/ReadOnlyEngine.java 70.83% <50.00%> (-0.43%) ⬇️
... and 506 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gbbafna gbbafna merged commit 79dbd2b into opensearch-project:2.x Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants