Change commit message and PR title to imperative mood#6177
Merged
andrross merged 1 commit intoopensearch-project:mainfrom Feb 3, 2023
Merged
Change commit message and PR title to imperative mood#6177andrross merged 1 commit intoopensearch-project:mainfrom
andrross merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Andrew Ross <andrross@amazon.com>
saratvemulapalli
approved these changes
Feb 3, 2023
Member
saratvemulapalli
left a comment
There was a problem hiding this comment.
Glad you did this on a Friday 😃
reta
approved these changes
Feb 3, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
kotwanikunal
approved these changes
Feb 3, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6177-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 61304a6a31cc2a0f722a867f515e5cb68d9050d6
# Push it to GitHub
git push --set-upstream origin backport/backport-6177-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
andrross
added a commit
to andrross/OpenSearch
that referenced
this pull request
Feb 3, 2023
This backports both opensearch-project#2572 and opensearch-project#6177. This was created by doing: ``` git checkout upstream/main .github/workflows/version.yml ``` Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
added a commit
that referenced
this pull request
Feb 4, 2023
Member
|
Is it "Increment" or "Increments"? |
Member
Author
"Increment", per the guidance here: https://cbea.ms/git-commit/ The way I remember this is by referring to how git itself formulates messages for things like |
Member
|
@andrross I think I am thrown off by dependapot which keeps saying "bumps". We should fix it probably. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because I'm a pedant.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.