Recover all translogs during relocation handoff for remote-backed indexes#6314
Merged
gbbafna merged 1 commit intoopensearch-project:mainfrom Feb 14, 2023
Merged
Recover all translogs during relocation handoff for remote-backed indexes#6314gbbafna merged 1 commit intoopensearch-project:mainfrom
gbbafna merged 1 commit intoopensearch-project:mainfrom
Conversation
…exes Signed-off-by: Ashish Singh <ssashish@amazon.com>
This was referenced Feb 14, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
approved these changes
Feb 14, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6314-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ac322595eb1838b68e4d9a46cf97cbe56b811aed
# Push it to GitHub
git push --set-upstream origin backport/backport-6314-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
Merged
6 tasks
Member
Author
|
Created manual PR - #6318 |
This was referenced Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashish Singh ssashish@amazon.com
Description
As discussed in #6214, during relocation certain documents indexed on the older primary were not seen on the new primary upon search. This was happening as recoverFromTranslog was recovering upto last known global checkpoint while it should be done upto
Long.Maxfor cases where remote translog store is enabled.OpenSearch/server/src/main/java/org/opensearch/index/shard/IndexShard.java
Lines 4314 to 4317 in 49d9a90
When remote translog is enabled, then remote store acts as the source of truth for storing translogs. During relocation we reset engine to writeable engine. When this happens, we initialise the RemoteFsTranslog which downloads all the translogs from remote store. The fix is to replay all the translogs here.
Issues Resolved
This fixes #6214.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.