[Segment Replication] Add global primary shard balance constraint during allocation#6643
Merged
dreamer-89 merged 3 commits intoMar 15, 2023
Merged
Conversation
…ing allocation Signed-off-by: Suraj Singh <surajrider@gmail.com>
dreamer-89
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
gbbafna,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
saratvemulapalli,
setiah,
shwetathareja,
tlfeng and
xuezhou25
as code owners
Member
Author
|
@nknize @shwetathareja @Bukhtawar @mch2 : Request for review. |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6643 +/- ##
============================================
- Coverage 70.76% 70.69% -0.07%
+ Complexity 59141 59137 -4
============================================
Files 4803 4804 +1
Lines 283187 283188 +1
Branches 40837 40837
============================================
- Hits 200384 200212 -172
- Misses 66340 66571 +231
+ Partials 16463 16405 -58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
Cluster setup3 data nodes Benchmark usedIndex settingTest steps performedStart benchmark (nyc_taxis here) and then shut down OpenSearch process on one data node. This should result in primaries be distributed in remaining two nodes. Once the node is brought up, shards are balanced. With Without primary balanceShard distributionBenchmark reportWith primary balanceSnapshot of shard distributionBenchmark reportComparisonWithout primary balance is used as baseline and run with prefer_primary setting to true as contender. |
mch2
reviewed
Mar 15, 2023
| * balance per index and across all indices is maintained. | ||
| * @throws Exception | ||
| */ | ||
| public void testGlobalPrimaryAllocation() throws Exception { |
Member
There was a problem hiding this comment.
Should we also add a test case here for allocation/rebalance post failover with these constraints? To simulate rebalance when a shard comes back full of replicas.
Member
Author
There was a problem hiding this comment.
Re-balancing is only performed at per index level today. So, allocation on a multiple index failover scenario wouldn't be predictible. The per index allocation/rebalancing scenario is covered in existing ITs. The global re-balancing is tracked in #6642
mch2
approved these changes
Mar 15, 2023
Member
mch2
left a comment
mch2
left a comment
There was a problem hiding this comment.
LGTM @dreamer-89, thanks for this change and providing all the perf benchmarks.
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
…ing allocation (#6643) * [Segment Replication] Add global primary shard balance constraint during allocation Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add javadoc Signed-off-by: Suraj Singh <surajrider@gmail.com> * Fix testAllConstraints test to include all constraints Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> (cherry picked from commit ad823b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89
pushed a commit
that referenced
this pull request
Mar 15, 2023
…ing allocation (#6643) (#6690) * [Segment Replication] Add global primary shard balance constraint during allocation * Add javadoc * Fix testAllConstraints test to include all constraints --------- (cherry picked from commit ad823b6) Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mingshl
pushed a commit
to mingshl/OpenSearch-Mingshl
that referenced
this pull request
Mar 24, 2023
…ing allocation (opensearch-project#6643) * [Segment Replication] Add global primary shard balance constraint during allocation Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add javadoc Signed-off-by: Suraj Singh <surajrider@gmail.com> * Fix testAllConstraints test to include all constraints Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change is a follow up of #6422 where constraint based per index primary balance was introduced. This change adds a new constraint
isPrimaryShardsPerNodeBreachedwhich is marked breached if a node contains more than average number of primary shards across all indices. This is intentionally applied for allocation and will be applied for rebalancing as fast follow up tracked in #6642Issues Resolved
#6210
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.