Don't register destructiveDistroTest.docker twice

[dbwiddis]

Description

The destructiveDistroTest.docker task was already registered here:

OpenSearch/buildSrc/src/main/java/org/opensearch/gradle/test/DistroTestPlugin.java

Line 245 in c85d33e

lifecyleTasks.put(OpenSearchDistribution.Type.DOCKER, project.getTasks().register(taskPrefix + ".docker"));

Which is called here:

OpenSearch/buildSrc/src/main/java/org/opensearch/gradle/test/DistroTestPlugin.java

Line 107 in c85d33e

Map<OpenSearchDistribution.Type, TaskProvider<?>> lifecycleTasks = lifecycleTasks(project, "destructiveDistroTest");

Which causes duplicate registration here:

OpenSearch/buildSrc/src/main/java/org/opensearch/gradle/test/DistroTestPlugin.java

Line 124 in c85d33e

TaskProvider<Test> destructiveTask = configureTestTask(project, taskname, distribution, t -> {

This fixes the TODO by adding a test whether a task is already registered in place of the exception catch/warning.

Issues Resolved

Fixes #1640 (you're welcome).

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/13235/
• CommitID: bcb73ee
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[dbwiddis]

Gradle check failure: #6625 with pending PR fix #6748

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/13239/
• CommitID: bcb73ee

[codecov-commenter]

Codecov Report

Merging #6930 (bcb73ee) into main (c85d33e) will increase coverage by 0.06%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #6930      +/-   ##
============================================
+ Coverage     70.66%   70.72%   +0.06%     
- Complexity    59231    59282      +51     
============================================
  Files          4812     4812              
  Lines        283761   283759       -2     
  Branches      40917    40918       +1     
============================================
+ Hits         200519   200695     +176     
+ Misses        66784    66618     -166     
+ Partials      16458    16446      -12     

Impacted Files	Coverage Δ
...a/org/opensearch/gradle/test/DistroTestPlugin.java	0.00% <0.00%> (ø)

... and 492 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.