[BUG] Zstd new codec is a breaking change for kNN plugin: move custom-codecs from sandbox/modules to sandbox/plugins (so it won't be installed automatically)#7014
Merged
kotwanikunal merged 1 commit intoopensearch-project:mainfrom Apr 5, 2023
Conversation
…-codecs from sandbox/modules to sandbox/plugins (so it won't be installed automatically) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Contributor
Author
|
@mulugetam please |
Contributor
Author
|
Skipping changelog since the feature was not released yet |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Author
Hehe ... |
Member
|
please add "backport 2.x" label, original PR got backported to 2.x :( 3accec8 |
Contributor
Author
Yes, that's after merge, no worries :) We just need to pass the Docker rate limit ... |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
|
Hi @reta I deployed the fix now to Jenkins. Sorry about it. |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7014 +/- ##
============================================
- Coverage 70.77% 70.60% -0.18%
+ Complexity 59270 59211 -59
============================================
Files 4822 4823 +1
Lines 283940 283985 +45
Branches 40947 40953 +6
============================================
- Hits 200963 200497 -466
- Misses 66454 66985 +531
+ Partials 16523 16503 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kotwanikunal
approved these changes
Apr 5, 2023
kotwanikunal
pushed a commit
that referenced
this pull request
Apr 5, 2023
…-codecs from sandbox/modules to sandbox/plugins (so it won't be installed automatically) (#7014) (#7019) (cherry picked from commit c7d6cf5) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move custom-codecs from sandbox/modules to sandbox/plugins (so it won't be installed automatically)
Issues Resolved
Closes #7012
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.