Skip to content

[BUG] Zstd new codec is a breaking change for kNN plugin: move custom-codecs from sandbox/modules to sandbox/plugins (so it won't be installed automatically)#7014

Merged
kotwanikunal merged 1 commit intoopensearch-project:mainfrom
reta:issue-7012
Apr 5, 2023

Conversation

@reta
Copy link
Copy Markdown
Contributor

@reta reta commented Apr 5, 2023

Description

Move custom-codecs from sandbox/modules to sandbox/plugins (so it won't be installed automatically)

Issues Resolved

Closes #7012

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…-codecs from sandbox/modules to sandbox/plugins (so it won't be installed automatically)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta
Copy link
Copy Markdown
Contributor Author

reta commented Apr 5, 2023

@mulugetam please

@reta
Copy link
Copy Markdown
Contributor Author

reta commented Apr 5, 2023

Skipping changelog since the feature was not released yet

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2023

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Copy Markdown
Contributor Author

reta commented Apr 5, 2023

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE x

* **URL:** https://build.ci.opensearch.org/job/gradle-check/13549/

* **CommitID:** [a1a7732](https://github.com/opensearch-project/OpenSearch/commit/a1a7732c3d4a7b4999f2eb4cc2a1b15e7a5d97ab)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

Hehe ...

Execution failed for task ':test:fixtures:gcs-fixture:composeBuild'.
> Exit-code 1 when calling /usr/bin/docker-compose, stdout: Step 1/11 : FROM ubuntu:18.04

@martin-gaievski
Copy link
Copy Markdown
Member

please add "backport 2.x" label, original PR got backported to 2.x :( 3accec8

@reta
Copy link
Copy Markdown
Contributor Author

reta commented Apr 5, 2023

please add "backport 2.x" label, original PR got backported to 2.x :( 3accec8

Yes, that's after merge, no worries :) We just need to pass the Docker rate limit ...

@kotwanikunal kotwanikunal added the backport 2.x Backport to 2.x branch label Apr 5, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2023

Gradle Check (Jenkins) Run Completed with:

@peterzhuamazon
Copy link
Copy Markdown
Member

Hi @reta

I deployed the fix now to Jenkins.
If it fails again try to rerun.
It should login as a readonly user and increase the pull limit.

Sorry about it.
Thanks.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 5, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.60%. Comparing base (59e881b) to head (a1a7732).
⚠️ Report is 4015 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7014      +/-   ##
============================================
- Coverage     70.77%   70.60%   -0.18%     
+ Complexity    59270    59211      -59     
============================================
  Files          4822     4823       +1     
  Lines        283940   283985      +45     
  Branches      40947    40953       +6     
============================================
- Hits         200963   200497     -466     
- Misses        66454    66985     +531     
+ Partials      16523    16503      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kotwanikunal kotwanikunal merged commit c7d6cf5 into opensearch-project:main Apr 5, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 5, 2023
…-codecs from sandbox/modules to sandbox/plugins (so it won't be installed automatically) (#7014)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit c7d6cf5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Apr 5, 2023
…-codecs from sandbox/modules to sandbox/plugins (so it won't be installed automatically) (#7014) (#7019)

(cherry picked from commit c7d6cf5)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Zstd new codec is a breaking change for kNN plugin

5 participants