Change INDEX_SEARCHER threadpool to resizable to support task resource tracking#7502
Merged
reta merged 1 commit intoopensearch-project:mainfrom May 17, 2023
Merged
Conversation
cd88594 to
68beb41
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
68beb41 to
1480aba
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7502 +/- ##
============================================
- Coverage 70.54% 70.44% -0.11%
+ Complexity 59713 59674 -39
============================================
Files 4896 4896
Lines 286798 286798
Branches 41331 41331
============================================
- Hits 202334 202033 -301
- Misses 67761 68098 +337
+ Partials 16703 16667 -36
|
222c08f to
e8f742a
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Author
|
Seems like a known flaky test #7401 |
6c013b5 to
56790fb
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
56790fb to
0ba0ae3
Compare
reta
reviewed
May 17, 2023
...ClusterTest/java/org/opensearch/action/admin/cluster/node/tasks/ConcurrentSearchTasksIT.java
Outdated
Show resolved
Hide resolved
reta
reviewed
May 17, 2023
...ClusterTest/java/org/opensearch/action/admin/cluster/node/tasks/ConcurrentSearchTasksIT.java
Outdated
Show resolved
Hide resolved
Contributor
Have we figure out (and fixed) the flakiness part? thank you |
5f4554c to
6be87cb
Compare
Contributor
Author
|
@reta Yep the flakiness and your last round of comments are both addressed now. |
6be87cb to
6bad124
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
sohami
reviewed
May 17, 2023
server/src/test/java/org/opensearch/tasks/TaskResourceTrackingServiceTests.java
Show resolved
Hide resolved
…e tracking Signed-off-by: Jay Deng <jayd0104@gmail.com>
6bad124 to
3e11e38
Compare
sohami
approved these changes
May 17, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
May 17, 2023
This was referenced May 22, 2023
jed326
added a commit
to jed326/OpenSearch
that referenced
this pull request
May 25, 2023
…ort task resource tracking (opensearch-project#7502) (cherry picked from commit 054cccd) Signed-off-by: Jay Deng <jayd0104@gmail.com>
6 tasks
jed326
added a commit
to jed326/OpenSearch
that referenced
this pull request
May 25, 2023
…ort task resource tracking (opensearch-project#7502) (cherry picked from commit 054cccd) Signed-off-by: Jay Deng <jayd0104@gmail.com>
stephen-crawford
pushed a commit
to stephen-crawford/OpenSearch
that referenced
this pull request
May 31, 2023
…e tracking (opensearch-project#7502) Signed-off-by: Jay Deng <jayd0104@gmail.com>
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…ort task resource tracking (opensearch-project#7502) (opensearch-project#7765) (cherry picked from commit 054cccd) Signed-off-by: Jay Deng <jayd0104@gmail.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…e tracking (opensearch-project#7502) Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the INDEX_SEARCHER threadpool type to
QueueResizableOpenSearchThreadPoolExecutorto support task resource tracking for concurrent segment search.ConcurrentSearchTasksITtest to validate that multiple threads are reporting resource stats for the same task with concurrent search enabled. Note that this is separate from [Concurrent Segment Search] Enable Search ITs with Concurrent Segment Search #7440.testStartingTrackingHandlesMultipleThreadsPerTasktoTaskResourceTrackingServiceTeststo check thatTaskResourceTrackingServiceproperly handles multiple threads per task.We already have existing tests for passing thread context between threadpools so I did not add any more tests related to
TaskAwareRunnable.Related Issues
#7425
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Resolves #7425