Fix version check for search pipelines REST test#7618
Merged
Conversation
As @reta pointed out, these tests should be skipped for versions less than 2.7.0, but the skip version ranges are inclusive. So, the upper bound of the range should be 2.6.99. This brings a change made for opensearch-project#7589 onto the main branch. Signed-off-by: Michael Froh <froh@amazon.com>
msfroh
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
saratvemulapalli,
setiah,
shwetathareja and
tlfeng
as code owners
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7618 +/- ##
============================================
+ Coverage 70.72% 70.75% +0.02%
- Complexity 55995 55999 +4
============================================
Files 4663 4663
Lines 265479 265479
Branches 39005 39005
============================================
+ Hits 187757 187833 +76
+ Misses 61835 61700 -135
- Partials 15887 15946 +59 |
reta
approved these changes
May 18, 2023
bharath-techie
pushed a commit
to bharath-techie/OpenSearch
that referenced
this pull request
May 23, 2023
…7618) As @reta pointed out, these tests should be skipped for versions less than 2.7.0, but the skip version ranges are inclusive. So, the upper bound of the range should be 2.6.99. This brings a change made for opensearch-project#7589 onto the main branch. Signed-off-by: Michael Froh <froh@amazon.com> Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
stephen-crawford
pushed a commit
to stephen-crawford/OpenSearch
that referenced
this pull request
May 31, 2023
…7618) As @reta pointed out, these tests should be skipped for versions less than 2.7.0, but the skip version ranges are inclusive. So, the upper bound of the range should be 2.6.99. This brings a change made for opensearch-project#7589 onto the main branch. Signed-off-by: Michael Froh <froh@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…7618) As @reta pointed out, these tests should be skipped for versions less than 2.7.0, but the skip version ranges are inclusive. So, the upper bound of the range should be 2.6.99. This brings a change made for opensearch-project#7589 onto the main branch. Signed-off-by: Michael Froh <froh@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As @reta pointed out, these tests should be skipped for versions less than 2.7.0, but the skip version ranges are inclusive. So, the upper bound of the range should be 2.6.99.
This brings a change made for
#7589 onto the main branch.
Related Issues
Related to #7589
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.