[Backport 2.x] search_after query optimization with shard/segment level short cuttin…#7727
Merged
andrross merged 1 commit intoopensearch-project:2.xfrom May 24, 2023
Merged
Conversation
opensearch-project#7453) * search_after query optimization with shard/segment level short cutting Signed-off-by: Chaitanya Gohel <gashutos@amazon.com> * Correcting logical && operator Signed-off-by: Chaitanya Gohel <gashutos@amazon.com> * Addressig review comments Signed-off-by: Chaitanya Gohel <gashutos@amazon.com> * Correcting NPE Signed-off-by: gashutos <gashutos@amazon.com> * Fixing failed integ Signed-off-by: gashutos <gashutos@amazon.com> * Addressing review comments and fixing some more integ Signed-off-by: Chaitanya Gohel <gashutos@amazon.com> * Addressing review comments and fixing some more integ Signed-off-by: Chaitanya Gohel <gashutos@amazon.com> * Refactoring a bit to aggressive null checks Signed-off-by: Chaitanya Gohel <gashutos@amazon.com> * Adding unit tests for MinAndMax methods Signed-off-by: gashutos <gashutos@amazon.com> --------- Signed-off-by: Chaitanya Gohel <gashutos@amazon.com> Signed-off-by: gashutos <gashutos@amazon.com> Signed-off-by: Chaitanya Gohel <104654647+gashutos@users.noreply.github.com>
gashutos
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
saratvemulapalli,
setiah,
shwetathareja and
tlfeng
as code owners
reta
approved these changes
May 24, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Author
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7727 +/- ##
============================================
+ Coverage 70.49% 70.56% +0.06%
- Complexity 56373 56378 +5
============================================
Files 4663 4663
Lines 267604 267646 +42
Branches 39626 39637 +11
============================================
+ Hits 188658 188854 +196
+ Misses 62686 62480 -206
- Partials 16260 16312 +52
|
Contributor
Author
|
We should relax this |
andrross
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7453