[Remote Segment Store] Use files from segmentInfosSnapshot in upload#8487
Merged
sachinpkale merged 7 commits intoopensearch-project:mainfrom Jul 18, 2023
Merged
Conversation
Contributor
Gradle Check (Jenkins) Run Completed with:
|
3fd4d8b to
45b2571
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
Author
|
Taking a look at test failures in |
mch2
reviewed
Jul 11, 2023
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForcemergeIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForcemergeIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForcemergeIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForcemergeIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForcemergeIT.java
Outdated
Show resolved
Hide resolved
Member
Author
|
New integ tests are executed 180+ times on local to avoid checking in flaky tests. |
ashking94
reviewed
Jul 17, 2023
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForceMergeIT.java
Outdated
Show resolved
Hide resolved
ashking94
reviewed
Jul 17, 2023
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForceMergeIT.java
Show resolved
Hide resolved
ashking94
reviewed
Jul 17, 2023
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForceMergeIT.java
Show resolved
Hide resolved
ashking94
reviewed
Jul 17, 2023
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForceMergeIT.java
Show resolved
Hide resolved
b8c3aa8 to
3590576
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
mch2
approved these changes
Jul 17, 2023
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForceMergeIT.java
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForceMergeIT.java
Outdated
Show resolved
Hide resolved
3590576 to
cec103f
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
added 7 commits
July 18, 2023 15:27
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
cec103f to
373976d
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8487-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 230a06daee9c8484e38d6aad867a98c3c10c2485
# Push it to GitHub
git push --set-upstream origin backport/backport-8487-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jul 19, 2023
…pensearch-project#8487) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com>
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jul 19, 2023
…pensearch-project#8487) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com>
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jul 19, 2023
…pensearch-project#8487) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
…pensearch-project#8487) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com>
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
…pensearch-project#8487) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…pensearch-project#8487) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RemoteStoreRefreshListeneris one of the refresh listeners that uploads segments to remote segment store.segmentInfosSnapshotfrom InternalEngine and adds files referenced bysegments_Nfile.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.