Skip to content

[Backport 2.x] Use CloseableRetryableRefreshListener to drain ongoing after refresh tasks on relocation (#8683)#8773

Merged
sachinpkale merged 1 commit into
opensearch-project:2.xfrom
ashking94:backport-8683
Jul 19, 2023
Merged

[Backport 2.x] Use CloseableRetryableRefreshListener to drain ongoing after refresh tasks on relocation (#8683)#8773
sachinpkale merged 1 commit into
opensearch-project:2.xfrom
ashking94:backport-8683

Conversation

@ashking94
Copy link
Copy Markdown
Member

  • Use CloesableRetryableRefreshListener to drain ongoing after refresh tasks on relocation ---------
    Signed-off-by: Ashish Singh ssashish@amazon.com

Description

This backports 2ba1157 from #8683

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…tasks on relocation (opensearch-project#8683)

* Use CloesableRetryableRefreshListener to drain ongoing after refresh tasks on relocation
---------
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 19, 2023

Codecov Report

Merging #8773 (6015205) into 2.x (6548b5f) will decrease coverage by 0.02%.
The diff coverage is 76.34%.

@@             Coverage Diff              @@
##                2.x    #8773      +/-   ##
============================================
- Coverage     70.70%   70.69%   -0.02%     
+ Complexity    57383    57377       -6     
============================================
  Files          4758     4759       +1     
  Lines        271560   271587      +27     
  Branches      40031    40035       +4     
============================================
- Hits         192006   191986      -20     
- Misses        63093    63112      +19     
- Partials      16461    16489      +28     
Impacted Files Coverage Δ
...pensearch/common/settings/FeatureFlagSettings.java 50.00% <ø> (ø)
.../java/org/opensearch/common/util/FeatureFlags.java 91.66% <ø> (-0.65%) ⬇️
server/src/main/java/org/opensearch/node/Node.java 86.02% <ø> (-0.02%) ⬇️
...opensearch/search/builder/SearchSourceBuilder.java 67.92% <0.00%> (-2.52%) ⬇️
...nsearch/search/pipeline/SearchPipelineService.java 85.58% <0.00%> (+0.58%) ⬆️
.../main/java/org/opensearch/index/IndexSettings.java 85.92% <33.33%> (-0.54%) ⬇️
...nsearch/index/shard/CheckpointRefreshListener.java 84.61% <50.00%> (-7.06%) ⬇️
...index/shard/CloseableRetryableRefreshListener.java 73.33% <73.33%> (ø)
...search/index/shard/RemoteStoreRefreshListener.java 84.45% <95.23%> (+1.84%) ⬆️
.../main/java/org/opensearch/action/ActionModule.java 96.33% <100.00%> (-0.01%) ⬇️
... and 3 more

... and 488 files with indirect coverage changes

@sachinpkale sachinpkale merged commit 416665b into opensearch-project:2.x Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants