Skip to content

[Backport 2.x] [Refactor] Network and Transport common classes to Libraries (#9073)#9078

Merged
nknize merged 1 commit intoopensearch-project:2.xfrom
nknize:backport/backport-9073-to-2.x
Aug 2, 2023
Merged

[Backport 2.x] [Refactor] Network and Transport common classes to Libraries (#9073)#9078
nknize merged 1 commit intoopensearch-project:2.xfrom
nknize:backport/backport-9073-to-2.x

Conversation

@nknize
Copy link
Copy Markdown
Contributor

@nknize nknize commented Aug 2, 2023

Backport 8afb22a from #9073.

…rch-project#9073)

This commit refactors the following network and transport libraries to
the opensearch common and core libraries respectively:

* o.o.common.network.Cidrs -> :libs:opensearch-common
* o.o.common.network.InetAddresses -> :libs:opensearch-common
* o.o.common.network.NetworkAddress -> :libs:opensearch-common
* o.o.common.transport.NetworkExceptionHelper -> :libs:opensearch-common
* o.o.common.transport.PortsRange -> :libs:opensearch-common

* o.o.common.transport.TransportAddress -> :libs:opensearch-core
* o.o.common.transport.BoundTransportAddress -> :libs:opensearch-core
* o.o.transport.TransportMessage -> :libs:opensearch-core
* o.o.transport.TransportResponse -> :libs:opensearch-core

The purpose is to reduce the change surface area of the core APIs to
minimize impact to downstream consumers while moving toward establishing
a formal API for cloud native or serverless implementations.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 8afb22a)
@nknize nknize added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments skip-changelog v2.10.0 labels Aug 2, 2023
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Compatibility status:

> Task :checkCompatibility
Checking compatibility for: https://github.com/opensearch-project/opensearch-oci-object-storage.git with ref: 2.x
Skipping compatibility check for https://github.com/opensearch-project/opensearch-oci-object-storage.git
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git]

BUILD SUCCESSFUL in 23m 14s

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 2, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      3 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 2, 2023

Codecov Report

Merging #9078 (74ab3e7) into 2.x (21723f0) will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #9078      +/-   ##
============================================
+ Coverage     70.68%   70.82%   +0.13%     
- Complexity    57345    57444      +99     
============================================
  Files          4749     4749              
  Lines        271399   271399              
  Branches      40055    40055              
============================================
+ Hits         191851   192219     +368     
+ Misses        63090    62672     -418     
- Partials      16458    16508      +50     
Files Changed Coverage Δ
...main/java/org/opensearch/common/network/Cidrs.java 77.77% <ø> (ø)
...a/org/opensearch/common/network/InetAddresses.java 94.83% <ø> (ø)
.../org/opensearch/common/network/NetworkAddress.java 100.00% <ø> (ø)
...earch/common/transport/NetworkExceptionHelper.java 45.83% <ø> (ø)
...va/org/opensearch/common/transport/PortsRange.java 87.09% <ø> (ø)
...h/core/common/transport/BoundTransportAddress.java 91.17% <ø> (ø)
...search/core/common/transport/TransportAddress.java 79.48% <ø> (ø)
...rg/opensearch/core/transport/TransportMessage.java 100.00% <ø> (ø)
...g/opensearch/core/transport/TransportResponse.java 85.71% <ø> (ø)
...iscovery/azure/classic/AzureSeedHostsProvider.java 0.00% <ø> (ø)
... and 95 more

... and 439 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PRs or issues specific to backporting features or enhancments enhancement Enhancement or improvement to existing feature or request skip-changelog v2.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants