Referencing default and best compressions codecs as their algo name#9123
Merged
reta merged 1 commit intoopensearch-project:mainfrom Aug 8, 2023
Merged
Conversation
sarthakaggarwal97
force-pushed
the
codec-algo-name
branch
from
643f060 to
4e1a383
Compare
sarthakaggarwal97
changed the title
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
sarthakaggarwal97
force-pushed
the
codec-algo-name
branch
from
4e1a383 to
bb6169b
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9123 +/- ##
============================================
- Coverage 71.06% 70.98% -0.08%
+ Complexity 57314 57284 -30
============================================
Files 4766 4765 -1
Lines 270453 270482 +29
Branches 39555 39552 -3
============================================
- Hits 192197 192010 -187
- Misses 62045 62272 +227
+ Partials 16211 16200 -11
|
sarthakaggarwal97
force-pushed
the
codec-algo-name
branch
from
bb6169b to
b449430
Compare
Contributor
|
Compatibility status: |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
sarthakaggarwal97
force-pushed
the
codec-algo-name
branch
from
b449430 to
0ed56e7
Compare
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
force-pushed
the
codec-algo-name
branch
from
0ed56e7 to
393dbf1
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
|
Compatibility status: |
Contributor
|
Compatibility status: |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
sarthakaggarwal97
requested review from
Bukhtawar,
CEHENKLE,
anasalkouz,
andrross,
dblock,
gbbafna,
kartg,
kotwanikunal,
mch2,
nknize,
reta and
setiah
as code owners
sarthakaggarwal97
requested review from
VachaShah,
dbwiddis,
dreamer-89,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
tlfeng
as code owners
dbwiddis
approved these changes
Aug 7, 2023
Poojita-Raj
approved these changes
Aug 8, 2023
mgodwan
approved these changes
Aug 8, 2023
reta
approved these changes
Aug 8, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-9123-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3713bcb1ab69d18cc990cd36f91f5b5261b71132
# Push it to GitHub
git push --set-upstream origin backport/backport-9123-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
Contributor
|
@sarthakaggarwal97 could you please send manual backport to |
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Aug 8, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
Merged
6 tasks
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Aug 8, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Aug 8, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Aug 8, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Aug 9, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Aug 9, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Aug 10, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Aug 11, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Aug 11, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 3713bcb)
reta
pushed a commit
that referenced
this pull request
Aug 11, 2023
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The users will be able to set the codecs in the index settings using their algorithm names. This will help the user get visibility on the algorithm being used in the background for compression
Related Issues
Resolves #8695
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.