[Backport 2.x] Do not evaluate shard_size and shard_min_doc_count at segment slice level#9211
Merged
reta merged 1 commit intoopensearch-project:2.xfrom Aug 10, 2023
Merged
Conversation
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
|
Compatibility status: |
jed326
changed the title
jed326
force-pushed
the
backport-9085-to-2.x
branch
from
bce6a05 to
1023410
Compare
Contributor
|
Compatibility status: |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
jed326
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja,
sohami and
tlfeng
as code owners
Contributor
Author
…evel (opensearch-project#9085) * Use BucketCountThresholds in InternalTerms and InternalAggregations and do not apply shard level thresholds at slice level for Concurrent Segment Search Signed-off-by: Jay Deng <jayd0104@gmail.com> * Addressing comments Signed-off-by: Jay Deng <jayd0104@gmail.com> * Re-introduce shardSize member to InternalMultiTerms and InternalMappedTerms Signed-off-by: Jay Deng <jayd0104@gmail.com> * Introduce LocalBucketCountThresholds for local size and min_doc_count values Signed-off-by: Jay Deng <jayd0104@gmail.com> --------- Signed-off-by: Jay Deng <jayd0104@gmail.com>
jed326
force-pushed
the
backport-9085-to-2.x
branch
from
1023410 to
993fdf1
Compare
Contributor
|
Compatibility status: |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #9211 +/- ##
============================================
- Coverage 70.85% 70.81% -0.05%
+ Complexity 57522 57460 -62
============================================
Files 4756 4757 +1
Lines 271788 271790 +2
Branches 40086 40090 +4
============================================
- Hits 192588 192476 -112
- Misses 62703 62859 +156
+ Partials 16497 16455 -42
|
reta
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport for #8860 #9085
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.