Fix flaky test SegmentReplicationIT.testDeleteOperations.#9244
Merged
kotwanikunal merged 1 commit intoopensearch-project:mainfrom Aug 11, 2023
Merged
Fix flaky test SegmentReplicationIT.testDeleteOperations.#9244kotwanikunal merged 1 commit intoopensearch-project:mainfrom
kotwanikunal merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Marc Handalian <handalm@amazon.com>
Poojita-Raj
approved these changes
Aug 10, 2023
Contributor
|
Compatibility status: |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9244 +/- ##
============================================
+ Coverage 71.03% 71.15% +0.11%
- Complexity 57318 57386 +68
============================================
Files 4770 4770
Lines 270540 270524 -16
Branches 39561 39558 -3
============================================
+ Hits 192186 192484 +298
+ Misses 62147 61821 -326
- Partials 16207 16219 +12
|
kotwanikunal
approved these changes
Aug 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
Signed-off-by: Marc Handalian <handalm@amazon.com> (cherry picked from commit ab08d73) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal
pushed a commit
that referenced
this pull request
Aug 11, 2023
) (cherry picked from commit ab08d73) Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
linuxpi
pushed a commit
to linuxpi/OpenSearch
that referenced
this pull request
Aug 14, 2023
…-project#9244) Signed-off-by: Marc Handalian <handalm@amazon.com>
linuxpi
pushed a commit
to linuxpi/OpenSearch
that referenced
this pull request
Aug 16, 2023
…-project#9244) Signed-off-by: Marc Handalian <handalm@amazon.com>
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
…-project#9244) Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
…-project#9244) Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…-project#9244) Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes SegmentReplicationIT.testDeleteOperations which can occasionally fail when no docs are indexed. Fixed by ensuring at least one doc is indexed and flagged for deletion. Also reduced the doc count potentially indexed to speed up the test.
Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.