docCountError must be 0 for shard level reduce#9246
Merged
sohami merged 1 commit intoopensearch-project:mainfrom Aug 12, 2023
Merged
docCountError must be 0 for shard level reduce#9246sohami merged 1 commit intoopensearch-project:mainfrom
sohami merged 1 commit intoopensearch-project:mainfrom
Conversation
jed326
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja,
sohami and
tlfeng
as code owners
Contributor
Author
Contributor
|
Compatibility status: |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9246 +/- ##
============================================
- Coverage 71.09% 71.01% -0.08%
+ Complexity 57364 57265 -99
============================================
Files 4770 4770
Lines 270548 270548
Branches 39563 39563
============================================
- Hits 192334 192135 -199
- Misses 62036 62157 +121
- Partials 16178 16256 +78
|
sohami
reviewed
Aug 11, 2023
server/src/main/java/org/opensearch/search/aggregations/bucket/terms/InternalTerms.java
Show resolved
Hide resolved
Signed-off-by: Jay Deng <jayd0104@gmail.com>
Contributor
Author
Contributor
|
Compatibility status: |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
sohami
approved these changes
Aug 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 12, 2023
Signed-off-by: Jay Deng <jayd0104@gmail.com> (cherry picked from commit db768d1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Aug 12, 2023
(cherry picked from commit db768d1) Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
linuxpi
pushed a commit
to linuxpi/OpenSearch
that referenced
this pull request
Aug 14, 2023
Signed-off-by: Jay Deng <jayd0104@gmail.com>
linuxpi
pushed a commit
to linuxpi/OpenSearch
that referenced
this pull request
Aug 16, 2023
Signed-off-by: Jay Deng <jayd0104@gmail.com>
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #8860, the shard_size parameters are not applied until the shard level reduce. This means that no bucket candidates will be eliminated until the reduce phase, which also means there should be no doc_count_error at the slice level reduce. This change fixes that and the test failures in #9209
Related Issues
Resolves #9209
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.