[Remote Store] Avoiding Translog Deletion in case of relocating shards. #9603
Closed
gbbafna wants to merge 3 commits intoopensearch-project:mainfrom
Closed
[Remote Store] Avoiding Translog Deletion in case of relocating shards. #9603gbbafna wants to merge 3 commits intoopensearch-project:mainfrom
gbbafna wants to merge 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
ashking94
requested changes
Aug 29, 2023
Member
ashking94
left a comment
ashking94
left a comment
There was a problem hiding this comment.
Looks good overall, lets add UTs/ITs. Thanks for the change.
.../src/internalClusterTest/java/org/opensearch/remotestore/RemoteIndexPrimaryRelocationIT.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/translog/RemoteFsTranslog.java
Outdated
Show resolved
Hide resolved
6 tasks
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dbwiddis,
dreamer-89,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja,
sohami and
tlfeng
as code owners
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Author
|
Failure not related to this change : #9580 |
Bukhtawar
reviewed
Aug 30, 2023
Contributor
Bukhtawar
left a comment
Bukhtawar
left a comment
There was a problem hiding this comment.
What if relocation is stuck and not all readers are needed, would we end up retaining readers for long? I would model this as a retention lease instead, the interface looks generic and cleaner that way
Bukhtawar
reviewed
Aug 30, 2023
| * | ||
| * @opensearch.internal | ||
| */ | ||
| static public class IndexShardConfigSupplier { |
Contributor
There was a problem hiding this comment.
The structure seems to be force-fitting this very specific use case. We should model it more generically
Contributor
|
This PR is stalled because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Primary to Primary relocation , there can be concurrent upload and download of translog.
While translog files are getting downloaded by new primary, it might hence be deleted by the relocating primary
Hence we need to avoid to deletion when shard is in
RELOCATINGstate .Related Issues
Resolves #9191
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.