Skip to content

fix test - RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileI…#9806

Closed
linuxpi wants to merge 1 commit intoopensearch-project:mainfrom
linuxpi:fix-primary-relocation-setup-issue
Closed

fix test - RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileI…#9806
linuxpi wants to merge 1 commit intoopensearch-project:mainfrom
linuxpi:fix-primary-relocation-setup-issue

Conversation

@linuxpi
Copy link
Copy Markdown
Contributor

@linuxpi linuxpi commented Sep 6, 2023 •
edited
Loading

…ndexing

Description

  • Fixes the IT - org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT#testPrimaryRelocationWhileIndexing

Related Issues

NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@linuxpi
fix test - RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileI…
e123630 
…ndexing

Signed-off-by: bansvaru <bansvaru@amazon.com>
@linuxpi linuxpi marked this pull request as ready for review September 6, 2023 09:36
psychbot
psychbot reviewed Sep 6, 2023
View reviewed changes
.../src/internalClusterTest/java/org/opensearch/remotestore/RemoteIndexPrimaryRelocationIT.java
protected Settings nodeSettings(int nodeOrdinal) {
return Settings.builder()
.put(super.nodeSettings(nodeOrdinal))
.put(remoteStoreClusterSettings(REPOSITORY_NAME, absolutePath))
Copy link
Copy Markdown
Member

@psychbot psychbot Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this will lead to creating a normal cluster and not remote store, wondering why never failed in #9105 while the PR was raised with latest main.

Will validate once and try to raise a PR with fix.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 6, 2023

Compatibility status:

Checks if related components are compatible with change e123630

Incompatible components

Incompatible components: [https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

@BhumikaSaini-Amazon BhumikaSaini-Amazon mentioned this pull request Sep 6, 2023
Merged
6 tasks
@linuxpi linuxpi closed this Sep 6, 2023
@linuxpi linuxpi deleted the fix-primary-relocation-setup-issue branch September 6, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@reta reta Awaiting requested review from reta

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@andrross andrross Awaiting requested review from andrross

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@dblock dblock Awaiting requested review from dblock

@gbbafna gbbafna Awaiting requested review from gbbafna

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal

@mch2 mch2 Awaiting requested review from mch2

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli

@shwetathareja shwetathareja Awaiting requested review from shwetathareja

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

@dbwiddis dbwiddis Awaiting requested review from dbwiddis

@sohami sohami Awaiting requested review from sohami

@msfroh msfroh Awaiting requested review from msfroh

+1 more reviewer

@psychbot psychbot psychbot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linuxpi @sachinpkale @psychbot