Skip to content

[Remote Store] Add support for Remote Translog Store upload stats in _nodes/stats/ API#9871

Merged
gbbafna merged 3 commits intoopensearch-project:2.10from
BhumikaSaini-Amazon:backport/backport-8908-to-2.10
Sep 7, 2023
Merged

[Remote Store] Add support for Remote Translog Store upload stats in _nodes/stats/ API#9871
gbbafna merged 3 commits intoopensearch-project:2.10from
BhumikaSaini-Amazon:backport/backport-8908-to-2.10

Conversation

@BhumikaSaini-Amazon
Copy link
Copy Markdown
Contributor

@BhumikaSaini-Amazon BhumikaSaini-Amazon commented Sep 7, 2023

Description

Backport #8908

Related Issues

#8311

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Bhumika Saini added 2 commits September 7, 2023 15:00
[Remote Store] Add support for Remote Translog Store upload stats in …
c44f9d6 
…_nodes/stats/ API (opensearch-project#8908)

---------

Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Change RTS stats version check to V_2_10_0
8a83cf0 
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
@BhumikaSaini-Amazon BhumikaSaini-Amazon force-pushed the backport/backport-8908-to-2.10 branch from 8faf86b to 8a83cf0 Compare September 7, 2023 09:31
@BhumikaSaini-Amazon BhumikaSaini-Amazon marked this pull request as ready for review September 7, 2023 09:31
ashking94
ashking94 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change 8faf86b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change 8a83cf0

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

Empty commit to retrigger build
dc64d73 
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change dc64d73

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 7, 2023

Codecov Report

Merging #9871 (dc64d73) into 2.10 (1c57571) will increase coverage by 0.10%.
Report is 4 commits behind head on 2.10.
The diff coverage is 78.14%.

@@             Coverage Diff              @@
##               2.10    #9871      +/-   ##
============================================
+ Coverage     70.76%   70.87%   +0.10%     
- Complexity    58157    58227      +70     
============================================
  Files          4811     4817       +6     
  Lines        274862   275066     +204     
  Branches      40401    40421      +20     
============================================
+ Hits         194495   194940     +445     
+ Misses        63778    63482     -296     
- Partials      16589    16644      +55
Files Changed Coverage Δ
...customcodecs/Lucene95CustomStoredFieldsFormat.java 74.07% <ø> (ø)
.../index/codec/customcodecs/ZstdCompressionMode.java 86.66% <ø> (ø)
.../codec/customcodecs/ZstdNoDictCompressionMode.java 79.45% <ø> (ø)
...in/cluster/remotestore/stats/RemoteStoreStats.java 96.24% <0.00%> (ø)
.../java/org/opensearch/index/codec/CodecAliases.java 0.00% <0.00%> (ø)
.../java/org/opensearch/index/codec/CodecService.java 63.15% <ø> (+5.15%) ⬆️
...rg/opensearch/index/remote/RemoteSegmentStats.java 86.15% <0.00%> (-12.10%) ⬇️
.../index/codec/customcodecs/ZstdDeprecatedCodec.java 50.00% <50.00%> (ø)
...arch/gateway/remote/RemoteClusterStateService.java 77.93% <78.12%> (-3.11%) ⬇️
...opensearch/index/translog/RemoteTranslogStats.java 82.08% <82.08%> (ø)
... and 12 more

... and 421 files with indirect coverage changes

@gbbafna gbbafna merged commit 373bc83 into opensearch-project:2.10 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashking94 ashking94 ashking94 approved these changes

@gbbafna gbbafna gbbafna approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BhumikaSaini-Amazon @ashking94 @gbbafna