Skip to content

[Backport] [2.x] Allow parameterization of tests with OpenSearchIntegTestCase.SuiteScopeTestCase annotation#9938

Closed
neetikasinghal wants to merge 2 commits intoopensearch-project:2.xfrom
neetikasinghal:backport-annotate-2.x
Closed

[Backport] [2.x] Allow parameterization of tests with OpenSearchIntegTestCase.SuiteScopeTestCase annotation#9938
neetikasinghal wants to merge 2 commits intoopensearch-project:2.xfrom
neetikasinghal:backport-annotate-2.x

Conversation

@neetikasinghal
Copy link
Copy Markdown
Contributor

@neetikasinghal neetikasinghal commented Sep 8, 2023

Description

Backport #9916

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@neetikasinghal @reta
Allow parameterization of tests with OpenSearchIntegTestCase.SuiteSco…
24cb7bf 
…peTestCase annotation (opensearch-project#9916)

Signed-off-by: Neetika Singhal <neetiks@amazon.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 8e5e54b)
@reta reta changed the title Allow parameterization of tests with OpenSearchIntegTestCase.SuiteScopeTestCase annotation [Backport] [2.x] Allow parameterization of tests with OpenSearchIntegTestCase.SuiteScopeTestCase annotation Sep 8, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2023

Compatibility status:

Checks if related components are compatible with change 24cb7bf

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL: null
  • CommitID: 24cb7bf
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnHungIOBeyondHealthyTimeout

@reta
Merge branch '2.x' into backport-annotate-2.x
60f0295 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Merging #9938 (60f0295) into 2.x (5505f09) will increase coverage by 0.11%.
Report is 1 commits behind head on 2.x.
The diff coverage is 81.52%.

@@             Coverage Diff              @@
##                2.x    #9938      +/-   ##
============================================
+ Coverage     70.77%   70.89%   +0.11%     
- Complexity    58164    58331     +167     
============================================
  Files          4817     4820       +3     
  Lines        275315   275383      +68     
  Branches      40456    40459       +3     
============================================
+ Hits         194867   195239     +372     
+ Misses        63724    63491     -233     
+ Partials      16724    16653      -71
Files Changed Coverage Δ
.../opensearch/telemetry/tracing/noop/NoopTracer.java 72.72% <ø> (+18.18%) ⬆️
...g/opensearch/transport/nio/NioTransportPlugin.java 25.00% <ø> (ø)
...a/org/opensearch/common/network/NetworkModule.java 92.00% <ø> (ø)
...ain/java/org/opensearch/plugins/NetworkPlugin.java 100.00% <ø> (ø)
...racing/ThreadContextBasedTracerContextStorage.java 93.10% <0.00%> (+20.68%) ⬆️
...etry/tracing/listener/TraceableActionListener.java 58.82% <58.82%> (ø)
.../org/opensearch/telemetry/tracing/SpanBuilder.java 91.66% <66.66%> (+3.43%) ⬆️
...lemetry/tracing/channels/TraceableHttpChannel.java 70.58% <70.58%> (ø)
...lemetry/tracing/channels/TraceableRestChannel.java 84.21% <84.21%> (ø)
...rg/opensearch/telemetry/tracing/DefaultTracer.java 100.00% <100.00%> (+6.45%) ⬆️
... and 7 more

... and 473 files with indirect coverage changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2023

Compatibility status:

Checks if related components are compatible with change 60f0295

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Copy Markdown
Contributor

reta commented Sep 11, 2023

@neetikasinghal could you please resolve conflicts? thank you

@neetikasinghal
Copy link
Copy Markdown
Contributor Author

neetikasinghal commented Sep 12, 2023

Created a new pull request for this as this branch had diverged: #10002

@neetikasinghal neetikasinghal deleted the backport-annotate-2.x branch September 12, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

+1 more reviewer

@Poojita-Raj Poojita-Raj Poojita-Raj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neetikasinghal @reta @Poojita-Raj