fix breaking change from core library refactor#1090
Merged
eirsep merged 1 commit intoopensearch-project:mainfrom Aug 16, 2023
Merged
fix breaking change from core library refactor#1090eirsep merged 1 commit intoopensearch-project:mainfrom
eirsep merged 1 commit intoopensearch-project:mainfrom
Conversation
6dbff40 to
75676c0
Compare
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1090 +/- ##
============================================
+ Coverage 67.60% 67.75% +0.15%
Complexity 105 105
============================================
Files 160 160
Lines 10343 10343
Branches 1522 1522
============================================
+ Hits 6992 7008 +16
+ Misses 2686 2668 -18
- Partials 665 667 +2
|
getsaurabh02
approved these changes
Aug 16, 2023
lezzago
approved these changes
Aug 16, 2023
AWSHurneyt
approved these changes
Aug 16, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.x
# Create a new branch
git switch --create backport-1090-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6e7a16b79d664bfa533ca87ba587d107c49f0bcc
# Push it to GitHub
git push --set-upstream origin backport-1090-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.xThen, create a pull request where the |
lezzago
pushed a commit
to lezzago/alerting-opensearch
that referenced
this pull request
Aug 21, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
1 task
lezzago
added a commit
that referenced
this pull request
Aug 23, 2023
* Update imports for files refactored in core PR #8157 (#1025) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Resolve core Xcontent and CircuitBreaker refactor (#1062) * Resolve core Xcontent refactor Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Resolve core CircuitBreaker refactor Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Resolve integ test issues with adding test dependency Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix breaking change from core library refactor (#1090) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * Resolve additional compile issues Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix bwc issues Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Update BWC version to deal with ktlint issues Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Update BWC version Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Disable BWC for non-bwc CIs Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Fix integ tests and update CI flows Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix breaking change from core library refactor