-
Notifications
You must be signed in to change notification settings - Fork 81
Deprecate the "Master" nomenclature #397
Description
Is your feature request related to a problem? Please describe.
OpenSearch repository is going to replace the terminology "master"with "cluster manager".
issue: opensearch-project/OpenSearch#472 (comment), with the plan for its terminology replacement.
Although the existing usages with "master" will be supported in OpenSearch version 2.x to keep the backwards compatibility, please prepare for the nomenclature change in advance, and replace all the usages with "master" terminology in the code base.
All the OpenSearch REST APIs and settings that contain "master" terminology will be deprecated in 2.0, and alternative usages will be added.
Describe the solution you'd like
Replace the terminology "master" with "cluster manager".
When being compatible with OpenSearch 2.0:
- Replace "master" in code comment and internal variable / class name.
Specifically, internal class name https://github.com/opensearch-project/anomaly-detection/blob/1.3.1.0/src/main/java/org/opensearch/ad/cluster/MasterEventListener.java
When being compatible with OpenSearch 3.0:
- Replace "master" in the reference to OpenSearch Java API
(most of the new APIs are available in version 2.2, exceptAcknowledgedResponse)- import org.opensearch.cluster.LocalNodeMasterListener -> LocalNodeClusterManagerListener
- clusterManagerService.onMaster() / offMaster() -> onclusterManager() / offClusterManager()
- DiscoveryNodes.Builder().masterNodeId() -> clusterManagerNodeId()
- import org.opensearch.action.support.master.AcknowledgedResponse -> import org.opensearch.action.support.clustermanager.AcknowledgedResponse (will be available in version 3.0)
Describe alternatives you've considered
None.
Additional context
None.