Fix MultiEntityResultTests.testQueryErrorEndRunNotNow after log4j upgrade to 2.25.3#1638
Closed
cwperks wants to merge 1 commit intoopensearch-project:mainfrom
Closed
Fix MultiEntityResultTests.testQueryErrorEndRunNotNow after log4j upgrade to 2.25.3#1638cwperks wants to merge 1 commit intoopensearch-project:mainfrom
cwperks wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
…rade to 2.25.3 Signed-off-by: Craig Perkins <cwperx@amazon.com>
3 tasks
Member
Author
|
Superseded by opensearch-project/OpenSearch#20320. It would be better to get this done in the core IMO. |
Member
|
Closing as the core PR has resolved this issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opening up this PR to show one way to resolve this exception. I'll follow-up with a more detailed analysis about why this fixes the issue.
Edit: I have found that the logic in https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/action/search/SearchPhaseExecutionException.java#L122-L127 is contributing to the issue. Removing that fixes the issue as well.
Related Issues
Resolves https://github.com/opensearch-project/anomaly-detection/actions/runs/20473890518/job/58836650085?pr=1636
Underlying log4j bug (will be fixed in 2.26): apache/logging-log4j2#3929
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.