[Feature/extensions] Build AD with OpenSearch 3.0 #645
[Feature/extensions] Build AD with OpenSearch 3.0 #645saratvemulapalli merged 3 commits intoopensearch-project:feature/extensionsfrom
Conversation
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
| // plugins.remove(0) | ||
| // plugins.add(firstPlugin) | ||
| // } | ||
| //} |
There was a problem hiding this comment.
Once we have Job Scheduler with 3.0-SNAPSHOT published to https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/ we can remove the commented code.
owaiskazi19
changed the title
| plugins.add(firstPlugin) | ||
| } | ||
| } | ||
| //task integTest(type: RestIntegTestTask) { |
There was a problem hiding this comment.
When commenting out blocks of code please add a comment and link to whatever issue is tracking the incompatibility. When someone comes across this in the future and asks "why is this commented out" they should be able to see if whatever the problem was has been resolved.
| @RunWith(PowerMockRunner.class) | ||
| @PowerMockRunnerDelegate(JUnitParamsRunner.class) | ||
| @PrepareForTest({ ParseUtils.class, Gson.class }) | ||
| @Ignore |
There was a problem hiding this comment.
I recall reading somewhere that we weren't supposed to use this (thus commenting things out). Am I misremembering?
There was a problem hiding this comment.
I tried to comment the tests the same way we did before. @saratvemulapalli any thoughts here?
There was a problem hiding this comment.
I remember trying it when trying to remove client and getting some sort of gradle check failure. If it's passing for you with these, you're probably fine.
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
|
hmm I have no idea why gradle check is running on this branch. |
Fixed in #647. |
3 participants
Signed-off-by: Owais Kazi owaiskazi19@gmail.com
Description
To integrate SDK with AD plugin, AD has to build with 3.0 OpenSearch as SDK is using the same. This PR adds that.
This also removes the dependency on Job Scheduler as JS is not available on
https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/because themainbranch of JS is still on2.2.0-SNAPSHOTIssues Resolved
Part of opensearch-project/opensearch-sdk-java#24
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.