fix mapping update not replicated when only new field is added#1642
Open
nhiemngo wants to merge 1 commit intoopensearch-project:mainfrom
Open
fix mapping update not replicated when only new field is added#1642nhiemngo wants to merge 1 commit intoopensearch-project:mainfrom
nhiemngo wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Nhiem Ngo <nhiemngohoang@gmail.com>
nhiemngo
requested review from
ankitkala,
gbbafna,
krishna-ggk,
monusingh-1,
saikaranam-amazon and
soosinha
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes it so that adding only a new field to the leader index's mapping will trigger a replication to the follower. This was raised as a bug in #1430.
This behavior came from
pollForMetadata()where the code previously only checked if a property in the follower had been modified. The fix is to also check that the leader has more/fewer properties than the follower.Surprisingly there was a test for this behavior (don't update if only new field is added). However I don't find anything about this in the documentation. Given it was raised and accepted as a bug, PTAL and let me know how we should proceed.
Related Issues
Resolves #1430
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.