added groupId to pluginzip publication#568
Conversation
Signed-off-by: sricharanvuppu <srivuppu@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
============================================
- Coverage 75.08% 74.75% -0.33%
+ Complexity 1007 1003 -4
============================================
Files 141 141
Lines 4595 4595
Branches 506 506
============================================
- Hits 3450 3435 -15
- Misses 834 845 +11
- Partials 311 315 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM. Let's wait for confirmation from @prudhvigodithi incase anything else is required. |
|
Looks good, but should be back-ported to 2.x only during 2.4 release else the build would break. |
|
@prudhvigodithi Can we merge this to main |
|
Hey @sricharanvuppu, yes we can merge this PR, but lets not backport it to 2.x I would suggest to just wait until the following PR is backported to 2.x from core, else the distribution build would fail compiling cross-cluster-replication for 2.4 version. @bbarani @lukas-vlcek @dblock |
Signed-off-by: sricharanvuppu <srivuppu@amazon.com> Signed-off-by: sricharanvuppu <srivuppu@amazon.com> (cherry picked from commit 33571ca)
Signed-off-by: sricharanvuppu srivuppu@amazon.com
Description
Added
groupIdasorg.opensearch.plugininpluginZippublicationIssues Resolved
#534
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.