Skip to content

added groupId to pluginzip publication#568

Merged
prudhvigodithi merged 1 commit intomainfrom
srivuppu_groupId_pluginZip
Oct 12, 2022
Merged

added groupId to pluginzip publication#568
prudhvigodithi merged 1 commit intomainfrom
srivuppu_groupId_pluginZip

Conversation

@sricharanvuppu
Copy link
Copy Markdown
Member

@sricharanvuppu sricharanvuppu commented Sep 27, 2022

Signed-off-by: sricharanvuppu srivuppu@amazon.com

Description

Added groupId as org.opensearch.plugin in pluginZip publication

Issues Resolved

#534

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: sricharanvuppu <srivuppu@amazon.com>
@sricharanvuppu sricharanvuppu requested a review from a team September 27, 2022 06:51
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 27, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.75%. Comparing base (e1dc511) to head (e54bd0a).
⚠️ Report is 212 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #568      +/-   ##
============================================
- Coverage     75.08%   74.75%   -0.33%     
+ Complexity     1007     1003       -4     
============================================
  Files           141      141              
  Lines          4595     4595              
  Branches        506      506              
============================================
- Hits           3450     3435      -15     
- Misses          834      845      +11     
- Partials        311      315       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ankitkala
Copy link
Copy Markdown
Member

LGTM. Let's wait for confirmation from @prudhvigodithi incase anything else is required.

@prudhvigodithi
Copy link
Copy Markdown
Member

Looks good, but should be back-ported to 2.x only during 2.4 release else the build would break.
related PR opensearch-project/OpenSearch#4360
CC @lukas-vlcek

@sricharanvuppu
Copy link
Copy Markdown
Member Author

@prudhvigodithi Can we merge this to main

@prudhvigodithi
Copy link
Copy Markdown
Member

Hey @sricharanvuppu, yes we can merge this PR, but lets not backport it to 2.x I would suggest to just wait until the following PR is backported to 2.x from core, else the distribution build would fail compiling cross-cluster-replication for 2.4 version. @bbarani @lukas-vlcek @dblock
opensearch-project/OpenSearch#4360 (comment)
Thank you

@prudhvigodithi prudhvigodithi merged commit 33571ca into main Oct 12, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2022
Signed-off-by: sricharanvuppu <srivuppu@amazon.com>

Signed-off-by: sricharanvuppu <srivuppu@amazon.com>
(cherry picked from commit 33571ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants