Skip to content

Wrap a call to QatZipper with AccessController.doPrivileged. #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reta merged 3 commits into from
Jan 10, 2025
Merged

Wrap a call to QatZipper with AccessController.doPrivileged. #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7295dae
Grant qat-java a permission to modify arbitrary thread.
Jan 9, 2025
7b51b37
Wrap a QatZipper() inside AccessController.doPrivileged().
mulugetam Jan 10, 2025
10d7485
Fix GitHib action workflows (#212)
reta Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,11 @@ jobs:
# using the same image which is used by opensearch-build team to build the OpenSearch Distribution
# this image tag is subject to change as more dependencies and updates will arrive over time
image: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-version-linux }}
# need to switch to root so that github actions can install runner binary on container without permission issues.
options: --user root
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

options: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-start-options }}
Copy link
Copy Markdown
Collaborator

@reta reta Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, this change is in main already ...

steps:
- uses: actions/checkout@v3
- name: Run start commands
run: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-start-command }}
- uses: actions/checkout@v4
- name: Run Gradle (check)
run: |
# https://github.com/opensearch-project/opensearch-build/issues/4191
Expand All @@ -44,7 +42,7 @@ jobs:
os: [windows-latest, macos-13]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up JDK ${{ matrix.java }}
uses: actions/setup-java@v3
with:
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/org/opensearch/index/codec/customcodecs/QatZipperFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ public class QatZipperFactory {
* @param pmode polling mode.
*/
public static QatZipper createInstance(Algorithm algorithm, int level, Mode mode, int retryCount, PollingMode pmode) {
return new QatZipper(algorithm, level, mode, retryCount, pmode);
return java.security.AccessController.doPrivileged(
(java.security.PrivilegedAction<QatZipper>) () -> new QatZipper(algorithm, level, mode, retryCount, pmode)
);
}

/**
Expand Down