Skip to content

Update for Lucene 10.4#311

Merged
reta merged 10 commits intoopensearch-project:mainfrom
mulugetam:update-for-lucene-10.4
Mar 9, 2026
Merged

Update for Lucene 10.4#311
reta merged 10 commits intoopensearch-project:mainfrom
mulugetam:update-for-lucene-10.4

Conversation

@mulugetam
Copy link
Copy Markdown
Contributor

@mulugetam mulugetam commented Feb 27, 2026

Description

Update for Lucene 10.4.

Related Issues

Resolves #312

Check List

  • New functionality includes testing.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mulugetam
Copy link
Copy Markdown
Contributor Author

@reta @andrross Current main doesn't build. Please review the update for Lucene 10.4.

@mulugetam mulugetam force-pushed the update-for-lucene-10.4 branch from 389974a to f2eafd6 Compare February 27, 2026 10:47
@mulugetam
Copy link
Copy Markdown
Contributor Author

mulugetam commented Feb 27, 2026

Integration tests fail b/c the test cluster distribution still has 10.3.2. Should work once OpenSearch-3.6.0-SNAPSHOT picks the Lucene 10.4.0 bump.

Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com>
@ShawnQiang1
Copy link
Copy Markdown

@mulugetam I submitted a review comment, please take a look.

@andrross
Copy link
Copy Markdown
Member

andrross commented Mar 4, 2026

Thanks @mulugetam!

@reta Similar to my questions about the 2.19 bwc tests, what should the versions on main be? Currently it is this:

String previousVersion = System.getProperty("bwc.version.previous", "2.11.1.0")
String nextVersion = System.getProperty("bwc.version.next", "3.0.0.0")

which suggests we might not be testing the right thing here?

@reta
Copy link
Copy Markdown
Collaborator

reta commented Mar 7, 2026

Thanks @mulugetam , just a few nits please, LGTM otherwise

@reta
Copy link
Copy Markdown
Collaborator

reta commented Mar 7, 2026

Thanks @mulugetam!

@reta Similar to my questions about the 2.19 bwc tests, what should the versions on main be? Currently it is this:

String previousVersion = System.getProperty("bwc.version.previous", "2.11.1.0")
String nextVersion = System.getProperty("bwc.version.next", "3.0.0.0")

which suggests we might not be testing the right thing here?

Tnanks @andrross , we did a major overhaul in 2.12.x with codec naming, so we kept 2.11.x to make sure there are/were no regressions.

@andrross
Copy link
Copy Markdown
Member

andrross commented Mar 9, 2026

Tnanks @andrross , we did a major overhaul in 2.12.x with codec naming, so we kept 2.11.x to make sure there are/were no regressions.

@reta Actually, I think these defaults are not used because the CI workflow sets the branches which is then used to get the versions from those branches.

mulugetam and others added 8 commits March 9, 2026 11:29
…4QatStoredFieldsFormatTests.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4CustomStoredFieldsFormatTests.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4CustomStoredFieldsFormatTests.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4CustomStoredFieldsFormatTests.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4QatStoredFieldsFormatTests.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4QatStoredFieldsFormatTests.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4QatStoredFieldsFormatTests.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4QatStoredFieldsFormatTests.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4QatStoredFieldsFormatTests.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
@mulugetam
Copy link
Copy Markdown
Contributor Author

@reta I have applied the changes. Thanks!

@reta
Copy link
Copy Markdown
Collaborator

reta commented Mar 9, 2026

Tnanks @andrross , we did a major overhaul in 2.12.x with codec naming, so we kept 2.11.x to make sure there are/were no regressions.

@reta Actually, I think these defaults are not used because the CI workflow sets the branches which is then used to get the versions from those branches.

Ah, rIght, thanks @andrross

@reta reta merged commit e4c9af1 into opensearch-project:main Mar 9, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]main fails to build.

4 participants