Conversation
389974a to
f2eafd6
Compare
|
Integration tests fail b/c the test cluster distribution still has 10.3.2. Should work once OpenSearch-3.6.0-SNAPSHOT picks the Lucene 10.4.0 bump. |
Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com>
|
@mulugetam I submitted a review comment, please take a look. |
|
Thanks @mulugetam! @reta Similar to my questions about the 2.19 bwc tests, what should the versions on main be? Currently it is this: which suggests we might not be testing the right thing here? |
...est/java/org/opensearch/index/codec/customcodecs/Lucene104CustomStoredFieldsFormatTests.java
Outdated
Show resolved
Hide resolved
...est/java/org/opensearch/index/codec/customcodecs/Lucene104CustomStoredFieldsFormatTests.java
Outdated
Show resolved
Hide resolved
...est/java/org/opensearch/index/codec/customcodecs/Lucene104CustomStoredFieldsFormatTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/index/codec/customcodecs/Lucene104QatStoredFieldsFormatTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/index/codec/customcodecs/Lucene104QatStoredFieldsFormatTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/index/codec/customcodecs/Lucene104QatStoredFieldsFormatTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/index/codec/customcodecs/Lucene104QatStoredFieldsFormatTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/index/codec/customcodecs/Lucene104QatStoredFieldsFormatTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/index/codec/customcodecs/Lucene104QatStoredFieldsFormatTests.java
Outdated
Show resolved
Hide resolved
|
Thanks @mulugetam , just a few nits please, LGTM otherwise |
Tnanks @andrross , we did a major overhaul in 2.12.x with codec naming, so we kept 2.11.x to make sure there are/were no regressions. |
@reta Actually, I think these defaults are not used because the CI workflow sets the branches which is then used to get the versions from those branches. |
…4QatStoredFieldsFormatTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4CustomStoredFieldsFormatTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4CustomStoredFieldsFormatTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4CustomStoredFieldsFormatTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4QatStoredFieldsFormatTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4QatStoredFieldsFormatTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4QatStoredFieldsFormatTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4QatStoredFieldsFormatTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
…4QatStoredFieldsFormatTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: mulugetam <mulugeta.mammo@intel.com>
|
@reta I have applied the changes. Thanks! |
Ah, rIght, thanks @andrross |
Description
Update for Lucene 10.4.
Related Issues
Resolves #312
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.