Merged
Conversation
Signed-off-by: ps48 <pshenoy36@gmail.com>
ps48
requested review from
Swiddis,
TackAdam,
anirudha,
dai-chen,
joshuali925,
mengweieric,
penghuo,
sumukhswamy and
vamsimanohar
as code owners
Signed-off-by: ps48 <pshenoy36@gmail.com>
cwperks
reviewed
Jan 23, 2026
| OPENSEARCH_DASHBOARDS_VERSION: 'main' | ||
| OPENSEARCH_VERSION: '3.0.0-beta1' | ||
| OPENSEARCH_PLUGIN_VERSION: '3.0.0.0-beta1' | ||
| OPENSEARCH_VERSION: '3.5.0' |
Member
There was a problem hiding this comment.
FYI I believe we can get rid of these and get the value from this repo instead (either via package.json or opensearch_dashboards.json)
I'm trying to fix cypress, ftr and verify-binary-installation on cwperks#1
Member
There was a problem hiding this comment.
Main problem now is changing the steps to downloading the snapshots of the plugins. https://aws.oss.sonatype.org has been decommissioned and was replaced with https://ci.opensearch.org/ci/dbc/snapshots/maven/org/opensearch/plugin/opensearch-job-scheduler/3.5.0.0-SNAPSHOT/
ZilongX
approved these changes
Jan 23, 2026
cwperks
reviewed
Jan 23, 2026
|
|
||
| on: [push, pull_request] | ||
| env: | ||
| OPENSEARCH_VERSION: '3.0.0-beta1' |
Member
There was a problem hiding this comment.
FYI to fix this check simply requires changing uses: derek-ho/start-opensearch@v2 to uses: derek-ho/start-opensearch@v9
Signed-off-by: ps48 <pshenoy36@gmail.com>
joshuali925
approved these changes
Jan 23, 2026
TackAdam
approved these changes
Jan 23, 2026
Signed-off-by: ps48 <pshenoy36@gmail.com>
Signed-off-by: ps48 <pshenoy36@gmail.com>
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade the jspdf dependency from version 3.0.4 to 4.0.0 in the dashboards-reporting plugin.
Breaking Changes Analysis
jspdf 4.0.0 introduces one breaking change:
This change does not affect the dashboards-reporting plugin because:
public/components/visual_report/generate_report.ts(browser context)new jsPDF(),setFillColor(),rect(),addImage(), andsave()Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.