Added ACM for SLL and Discovery Mode Configurations#1645
Added ACM for SLL and Discovery Mode Configurations#1645asifsmohammed merged 2 commits intoopensearch-project:mainfrom
Conversation
| void invalid_InvalidPeerForwarderConfig_test(final String filePath) { | ||
| void invalid_InvalidPeerForwarderConfig_test(final String filePath) throws IOException { | ||
| // PeerForwarderConfiguration peerForwarderConfiguration = makeConfig(filePath); | ||
| // System.out.println(peerForwarderConfiguration.isSsl()); |
There was a problem hiding this comment.
Remove commented out code.
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| class AwsCloudMapPeerListProvider_CreateTest { |
There was a problem hiding this comment.
We should change this name pattern into AwsCloudMapPeerListProviderCreateTest or AwsCloudMapPeerListProviderCreationTest
| import static org.mockito.Mockito.when; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| class DnsPeerListProvider_CreateTest { |
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| class StaticPeerListProvider_CreateTest { |
Signed-off-by: Asif Sohail Mohammed <nsifmoh@amazon.com>
asifsmohammed
force-pushed
the
cpf-discovery-mode
branch
from
8f014bb to
dec8b47
Compare
Signed-off-by: Asif Sohail Mohammed <nsifmoh@amazon.com>
asifsmohammed
force-pushed
the
cpf-discovery-mode
branch
from
dec8b47 to
165201a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1645 +/- ##
============================================
- Coverage 93.95% 93.83% -0.12%
- Complexity 1220 1272 +52
============================================
Files 163 167 +4
Lines 3474 3652 +178
Branches 282 292 +10
============================================
+ Hits 3264 3427 +163
- Misses 146 156 +10
- Partials 64 69 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dlvenable
left a comment
dlvenable
left a comment
There was a problem hiding this comment.
This looks good. Thanks!
One high-level thought: There might be a good opportunity to use the plugin framework for discovery modes. This would make for a nested configuration and allow the addition of other discovery modes easily. I think it is fair to put that beyond the scope of this PR though.
Does it mean using pluginModel for Discover Mode? |
|
Yes. We could use the pluginModel for the discovery mode. This way, other discovery options can be provided without changing Data Prepper core. |
…ct#1645) * Added ACM for SLL and Discovery Mode Configurations Signed-off-by: Asif Sohail Mohammed <nsifmoh@amazon.com>
4 participants
Signed-off-by: Asif Sohail Mohammed nsifmoh@amazon.com
Description
Issues Resolved
Resolves #1591
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.