Peer-forwarder hostname verification#1778
Merged
dlvenable merged 1 commit intoopensearch-project:mainfrom Sep 17, 2022
Merged
Conversation
…ility to disable hostname verification. Generate test certificates with a SAN and document how to do it. Signed-off-by: David Venable <dlv@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1778 +/- ##
============================================
- Coverage 94.00% 93.89% -0.11%
- Complexity 1449 1453 +4
============================================
Files 188 188
Lines 4252 4261 +9
Branches 343 344 +1
============================================
+ Hits 3997 4001 +4
- Misses 174 179 +5
Partials 81 81
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
asifsmohammed
approved these changes
Sep 17, 2022
| @Test | ||
| void send_Events_to_an_unknown_server_should_throw() { | ||
| final PeerForwarderConfiguration peerForwarderConfiguration = createConfiguration( | ||
| true, ForwardingAuthentication.MUTUAL_TLS, ALTERNATE_SSL_CERTIFICATE_FILE, SSL_KEY_FILE, true); |
Collaborator
There was a problem hiding this comment.
nit: Is the key supposed to be ALTERNATE_SSL_KEY_FILE here?
Member
Author
There was a problem hiding this comment.
No, but I see how this is confusing. I am intentionally using the trusted key. But, I'm configuring the client to trust the alternate key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a few changes to support hostname verification:
ssl_insecure_disable_verification. When set totrue, this will disable server verification.localhost.Issues Resolved
Resolves #1775
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.