Added demo cert and key files#1813
Conversation
Signed-off-by: Asif Sohail Mohammed <nsifmoh@amazon.com>
Signed-off-by: Asif Sohail Mohammed <nsifmoh@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1813 +/- ##
=========================================
Coverage 93.94% 93.94%
Complexity 1472 1472
=========================================
Files 188 188
Lines 4307 4307
Branches 355 355
=========================================
Hits 4046 4046
Misses 177 177
Partials 84 84 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dlvenable
left a comment
There was a problem hiding this comment.
Can you add a README to the examples/certificates (or update one if it exists) and add the command you ran to generate the certificate. This will help the maintainers who one day have to re-generate these certificates.
Also, we may not want to be using the "test" certificate for the default. If we are keeping them the same, I'd recommend that we invert this relationship such that "test" is using the "examples/certificate".
I'm not sure if I understood it completely. So we want't to use these certificates in Core Peer Forwarder tests as well? Do we need a separate Openssl configuration in this directory? Also in the command the CN used it |
Signed-off-by: Asif Sohail Mohammed <nsifmoh@amazon.com>
I meant that rather than having the examples using the
I'm not sure we need the |
Signed-off-by: Asif Sohail Mohammed <nsifmoh@amazon.com>
Signed-off-by: Asif Sohail Mohammed nsifmoh@amazon.com
Description
Command used to generate the files as documented here:
Issues Resolved
Contributes towards #1699
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.